Add support for Cinemagraphs in articles #15097
Merged
+14
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbyford
force-pushed
the
add-support-for-cinemagraphs-in-articles
branch
from
941cffe to
ef520e6
Compare
simonbyford
commented
Jan 7, 2026
Contributor
Author
There was a problem hiding this comment.
I decided to rename this component to better reflect that it's no longer just used for Looping videos
Comment on lines
-496
to
-505
| /* | ||
| - MediaAtomBlockElement is used for self-hosted videos | ||
| - Historically, these videos have been self-hosted for legal or sensitive reasons | ||
| - These videos play in the `VideoAtom` component | ||
| - Looping videos, introduced in July 2025, are also self-hosted | ||
| - Thus they are delivered as a MediaAtomBlockElement | ||
| - However they need to display in a different video player | ||
| - We need to differentiate between the two forms of video | ||
| - We can do this by interrogating the atom's metadata, which includes the new attribute `videoPlayerFormat` | ||
| */ |
Contributor
Author
There was a problem hiding this comment.
I think this information can better be gleaned from git history but I am happy to be challenged on this
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
jonathonherbert
approved these changes
Jan 8, 2026
Contributor
jonathonherbert
left a comment
jonathonherbert
left a comment
There was a problem hiding this comment.
This all seems reasonable! Approving to unblock, but keen to test: I'll message in chat about that.
Contributor
|
All tested, thanks @simonbyford! |
|
Seen on PROD (merged by @simonbyford 11 minutes and 20 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds support for Cinemagraphs in articles.
Follows on from: #14843
Screenshots
Before
cinemagraph-before.mp4
After
cinemagraph-after.mp4