-
Notifications
You must be signed in to change notification settings - Fork 30
Add rendering support for reporter callouts #15082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
997590c to
03b9540
Compare
c397ad9 to
af53f7d
Compare
2e5e623 to
22bb80d
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
e398afc to
6db646e
Compare
6db646e to
cdde9e1
Compare
| /** | ||
| * A callout to readers to share tips with reporters | ||
| * | ||
| * ## TODO: check if this needs to be an island - possibly not as there's no user interaction beyond expanding the box |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO to be dropped
alexduf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm terrible at CSS, so I hope there's nothing wrong in there, the rest looks okay to me
e01cbb6 to
1b65705
Compare
1b65705 to
f7fa56d
Compare
|
Seen on PROD (merged by @philmcmahon 9 minutes and 9 seconds ago) Please check your changes! |
What does this change?
This PR adds rendering for reporter callouts. The associated frontend PR is here guardian/frontend#28497 with the composer change here https://github.com/guardian/flexible-content/pull/6004
Reporter callouts are a much simpler version of the existing (community) callouts, seeking to replace the 'quick guide' atoms that are used currently (e.g. here https://www.theguardian.com/law/2025/nov/06/qatar-linked-intelligence-operation-targeted-icc-prosecutor-karim-khan-alleged-victim) which cause problems for syndication partners.
I copied a lot of the rendering code for this from the existing 'CalloutBlockComponent' (mainly the use and styles for the ExpandingWrapper). It feels sufficiently different to have a different component though.
One thing I am a bit unsure about is the use of
--expandable-atom-text-hover- changing the colour of the title based off what Pillar we're on is in the figma designs for these new callouts, so I think it makes sense rather than just using--article-text(which is black in general I think).Other relevant PRs across the content pipeline:
Merge before this one:
Merge after this one:
Screenshots