Skip to content

The byline image on profile pages don't have an alt text #15059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ioannakok merged 2 commits into from
Jan 14, 2026
Merged

The byline image on profile pages don't have an alt text #15059

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0edfdc8
added a alt text to the byline image on profile pages
ashishpuliyel Dec 24, 2025
5598ab6
Merge branch 'main' into ap-add-alt-test-on-profilepages
ioannakok Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions dotcom-rendering/src/components/TagPageHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,13 @@ const imageStyle = css`
}
`;

const BylineImage = ({ image }: { image: string }) => {
const BylineImage = ({
image,
altText,
}: {
image: string;
altText: string;
}) => {
const sources = generateSources(image, [
{ breakpoint: breakpoints.mobile, width: 80 },
{ breakpoint: breakpoints.desktop, width: 100 },
Expand All @@ -281,7 +287,7 @@ const BylineImage = ({ image }: { image: string }) => {
return (
<>
<Sources sources={sources} />
<img alt="" src={fallback} css={imageStyle} />
<img alt={altText} src={fallback} css={imageStyle} />
</>
);
};
Expand Down Expand Up @@ -322,7 +328,10 @@ const HeaderImage = (props: { image: Props['image']; title: string }) => {
case 'byline':
return (
<HeaderPicture>
<BylineImage image={props.image.url} />
<BylineImage
image={props.image.url}
altText={`Headshot of ${props.title}`}
/>
</HeaderPicture>
);
case 'footballCrest':
Expand Down
Loading