Reduce the number of useEffects in self-hosted video
#15034
Merged
+101
−132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlander
force-pushed
the
doml/reduce-video-useeffects
branch
4 times, most recently
from
1f5fb23 to
eeacda2
Compare
domlander
changed the title
useEffects in self-hosted video
domlander
force-pushed
the
doml/reduce-video-useeffects
branch
from
eeacda2 to
4d09685
Compare
domlander
force-pushed
the
doml/reduce-video-useeffects
branch
from
4d09685 to
0f39f17
Compare
domlander
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
domlander
force-pushed
the
doml/reduce-video-useeffects
branch
from
81a30bd to
0f39f17
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
domlander
force-pushed
the
doml/reduce-video-useeffects
branch
from
56905d1 to
3fc87e8
Compare
domlander
force-pushed
the
doml/reduce-video-useeffects
branch
from
3fc87e8 to
570712b
Compare
github-actions
bot
removed
the
run_chromatic
abeddow91
approved these changes
Jan 22, 2026
Contributor
abeddow91
left a comment
abeddow91
left a comment
There was a problem hiding this comment.
This is great Dom! Thanks for refactoring this 👏
|
Seen on PROD (merged by @domlander 7 minutes and 58 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes redundant
useEffect's.Why?
Removing unnecessary Effects will make your code easier to follow, faster to run, and less error-prone.1
Footnotes
https://react.dev/learn/you-might-not-need-an-effect ↩