Improved performance, browser support, bugfixes

[bcherny]

Changelog:

• Minimized repaints by eliminating style queries on every step of the
  drag
• Generally improved performance
• Improved browser support
• Standardized event names (start -> dragstart, stop -> dragend)
• Lots of bugfixes (eliminated outline dragging, fixed
  border/margin/zindex querying)

[gtramontina]

Hey man. First of all, thanks for the contribution.

Before I merge your pull request, I have a few considerations about it...

• I ran the tests here and a great part of them are failing, could you please either fix the failures or rewrite the tests so they reflect the current behavior? And also add some tests around your improvements. To run the tests, simply open the file test/test.html on your browser, it'll run all existing tests in draggable.test.js.
• I have an app using the current draggable version working, so I simply replaced my version with yours and it didn't work... It blows up with the following error right when I click the element: "Uncaught ReferenceError: element is not defined - draggable.js:148"

Thanks a lot!

[bcherny]

Hi Guilherme,

I've actually fixed the script up a bit more, and turned it into a class so you can have multiple instances of draggables on the same page. I'll try to add tests along with the new changes sometime this weekend if that works.

Cheers,
-Boris

On Jun 26, 2012, at 10:00 PM, "Guilherme J. Tramontina"[email protected] wrote:

Hey man. First of all, thanks for the contribution.

Before I merge your pull request, I have a few considerations about it...

• I ran the tests here and a great part of them are failing, could you please either fix the failures or rewrite the tests so they reflect the current behavior? And also add some tests around your improvements. To run the tests, simply open the file test/test.html on your browser, it'll run all existing tests in draggable.test.js.
• I have an app using the current draggable version working, so I simply replaced my version with yours and it didn't work... It blows up with the following error right when I click the element: "Uncaught ReferenceError: element is not defined - draggable.js:148"

Thanks a lot!

---

Reply to this email directly or view it on GitHub:
#3 (comment)

[gtramontina]

We can already have multiple draggables on the same page, it is just a
matter of calling "draggable()" with the different elements.
Anyway, I'll wait for your next pull request. :-)

Thanks.

On Thu, Jun 28, 2012 at 6:26 PM, eighttrackmind <
[email protected]

wrote:

Hi Guilherme,

I've actually fixed the script up a bit more, and turned it into a class
so you can have multiple instances of draggables on the same page. I'll try
to add tests along with the new changes sometime this weekend if that works.

Cheers,
-Boris

On Jun 26, 2012, at 10:00 PM, "Guilherme J. Tramontina"<
[email protected]> wrote:

Hey man. First of all, thanks for the contribution.

Before I merge your pull request, I have a few considerations about it...

• I ran the tests here and a great part of them are failing, could you
  please either fix the failures or rewrite the tests so they reflect the
  current behavior? And also add some tests around your improvements. To run
  the tests, simply open the file test/test.html on your browser, it'll run
  all existing tests in draggable.test.js.
• I have an app using the current draggable version working, so I simply
  replaced my version with yours and it didn't work... It blows up with the
  following error right when I click the element: "Uncaught ReferenceError:
  element is not defined - draggable.js:148"

Thanks a lot!

---

Reply to this email directly or view it on GitHub:
#3 (comment)

---

Reply to this email directly or view it on GitHub:
#3 (comment)

[dumblob]

Any news here?