Gtk subclassing round 1 #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI is failing due to actions-rs/toolchain#124 |
|
Did you check against / take all those from gtk3-rs? |
sdroege
reviewed
Nov 17, 2020
sdroege
reviewed
Nov 17, 2020
sdroege
reviewed
Nov 17, 2020
sdroege
reviewed
Nov 17, 2020
sdroege
reviewed
Nov 17, 2020
sdroege
reviewed
Nov 17, 2020
GtkListBoxRow is similar to the gtk3 one, GtkListBox had all of it's vfunc removed & the rest are missing from gtk3. I don't think there are many we can copy from gtk3 other than the Cell* ones |
bilelmoussaoui
force-pushed
the
bilelmoussaoui/subclassing-round-1
branch
from
a7bbf4e to
0555f6b
Compare
sdroege
reviewed
Nov 17, 2020
ids1024
added a commit
to ids1024/gtk-rs
that referenced
this pull request
Dec 1, 2020
Was added to gtk4-rs in gtk-rs/gtk4-rs#57 This doesn't include the deprecated virtual methods in gtk3 that are not in gtk4. Those could be added, but new projects probably shouldn't be using them anyway.
ids1024
added a commit
to ids1024/gtk-rs
that referenced
this pull request
Dec 1, 2020
Was added to gtk4-rs in gtk-rs/gtk4-rs#57 This doesn't include the deprecated virtual methods in gtk3 that are not in gtk4. Those could be added, but new projects probably shouldn't be using them anyway.
ids1024
added a commit
to ids1024/gtk-rs
that referenced
this pull request
Dec 1, 2020
Was added to gtk4-rs in gtk-rs/gtk4-rs#57 This doesn't include the deprecated virtual methods in gtk3 that are not in gtk4. Those could be added, but new projects probably shouldn't be using them anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds subclassing support to the following types
GtkButtonGtkAdjustmentGtkListBoxRowGtkFlowBoxChildGtkDrawingAreaRemoves GtkHeaderBar because it's not derivable anymore
Part of #56