Fix doc icon for temporary v0.9 manual crates list #224
Conversation
| <a href="/gtk-rs-core/stable/latest/docs/cairo">🕮</a> | ||
| <a href="/gtk-rs-core/stable/latest/docs/cairo"> | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <svg width="181" height="105" version="1.1" viewBox="0 0 47.89 27.781" xmlns="http://www.w3.org/2000/svg" xmlns:cc="http://creativecommons.org/ns#" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"> |
There was a problem hiding this comment.
Instead of redeclaring the image multiple times, couldn't it be stored in a file instead?
There was a problem hiding this comment.
(Even if not redeclared, it's very hard to read anything, it's supposed to be a markdown file)
There was a problem hiding this comment.
This is a temporary (!!!) fix because we are still lacking the v0.9 docs for gtk3 in the new system (cc @bilelmoussaoui). The correct solution would just be {% include crates.html %} which generates it from a json file. But that would lead to incorrect docs links for now.
There was a problem hiding this comment.
ah i always forget about those. Let me fix them :)
There was a problem hiding this comment.
If you mean by that that we will generate the svg images directly into the HTML, please don't and create an image file instead.
There was a problem hiding this comment.
Then you have to fix it yourself. Coloring with filters seems like a complicated detour. I think there is also a way with iframes? But I never used it.
There was a problem hiding this comment.
You could also generate all svgs in the page with the required colors of course.
| @@ -36,7 +36,7 @@ The following table contains the most popular crates of **gtk-rs**. More informa | |||
| {% include crates.html %} | |||
| --> | |||
|
|
|||
| <table> | |||
| <table class="crates"> | |||
There was a problem hiding this comment.
Please remove this indent.
Original fix is in #217, but was not applied to the temporary manual crates list.
Closes #223