This repository was archived by the owner on Mar 1, 2019. It is now read-only.
add simple deref macro #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
May 27, 2018
gobject-subclass/src/deref.rs
Outdated
|
|
||
| #[macro_export] | ||
| macro_rules! gobject_subclass_deref( | ||
|
|
|
Looks generally good, thanks! |
This one is weird. Also you can get rid of the |
|
That error is odd indeed. I didn't even touch that part. |
|
That error seems to stem from this: |
|
#8 fixes the tests |
sdroege
reviewed
May 29, 2018
gobject-subclass/src/deref.rs
Outdated
| @@ -0,0 +1,26 @@ | |||
| #[macro_export] | |||
| macro_rules! gobject_subclass_deref( | |||
|
|
|||
|
Except for the empty line, this seems good to go :) Remove that and merge, thanks! |
vhdirk
added a commit
to vhdirk/gobject-subclass
that referenced
this pull request
Jun 7, 2018
* add simple deref macro * remove newline * remove unused import * Remove extra newline
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a really simple macro for the deref impl