Add support for libc::time_t and related types
#1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why but this breaks generation of safe bindings in unexpected ways -#[doc(alias = "g_get_real_name")]
-#[doc(alias = "get_real_name")]
-pub fn real_name() -> std::ffi::OsString {
- unsafe { from_glib_none(ffi::g_get_real_name()) }
-}
+//#[doc(alias = "g_get_real_name")]
+//#[doc(alias = "get_real_name")]
+//pub fn real_name() -> /*Unimplemented*/Basic: TimeT {
+// unsafe { TODO: call ffi:g_get_real_name() }
+//}For some reason |
|
Ah, because we hardcode the |
|
Has some pending problems in https://gitlab.gnome.org/GNOME/glib/-/issues/3311 but from our side this "works" from what I can see. |
|
@werdahias note that this just makes it "someone else's" problem, i.e. yours and somehow magically getting the correct type mappings in the |
|
@bilelmoussaoui What should we do about this? IMHO ready to be merged |
bilelmoussaoui
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowed since https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3967.
Fixes #1559