More tls bindings #83

MathieuDuponchelle · 2018-02-17T02:27:49Z

I only added the generated bindings, will happily fix anything that review points out, not yet comfortable enough to tell what's unsafely wrapped I'm afraid :)

EPashkin · 2018-02-17T06:16:19Z

src/auto/tls_interaction.rs

+        }
+    }
+
+    fn ask_password_async<'a, P: Into<Option<&'a Cancellable>>, Q: FnOnce(Result<(), Error>) + Send + 'static>(&self, password: &TlsPassword, cancellable: P, callback: Q) {


This must have FnOnce(Result<TlsInteractionResult, Error>) ... see ask_password return type,
so or ignore or make manual.
There will be also same error in others async functions for sure.

EPashkin · 2018-02-17T07:16:38Z

@MathieuDuponchelle please rebase on new master after #84 merged

sdroege · 2018-02-17T09:43:08Z

src/auto/tls_database.rs

+
+    fn lookup_certificate_for_handle<'a, 'b, P: Into<Option<&'a TlsInteraction>>, Q: Into<Option<&'b Cancellable>>>(&self, handle: &str, interaction: P, flags: TlsDatabaseLookupFlags, cancellable: Q) -> Result<Option<TlsCertificate>, Error>;
+
+    fn lookup_certificate_for_handle_async<'a, 'b, P: Into<Option<&'a TlsInteraction>>, Q: Into<Option<&'b Cancellable>>, R: FnOnce(Result<(), Error>) + Send + 'static>(&self, handle: &str, interaction: P, flags: TlsDatabaseLookupFlags, cancellable: Q, callback: R);


These async functions are all wrong because they ignore the non-bool return value of the finish function (it should be put as first the component of the Result in the closure). Need to be written manually for now, see gtk-rs/gir#535

Congrats for sending me down a new rabbit hole :P

You found the end of it already :)

Yep, should be all good now :)

sdroege · 2018-02-17T09:43:59Z

src/auto/tls_database.rs

+
+    fn lookup_certificate_issuer_async<'a, 'b, P: Into<Option<&'a TlsInteraction>>, Q: Into<Option<&'b Cancellable>>, R: FnOnce(Result<(), Error>) + Send + 'static>(&self, certificate: &TlsCertificate, interaction: P, flags: TlsDatabaseLookupFlags, cancellable: Q, callback: R);
+
+    //fn lookup_certificates_issued_by<'a, 'b, P: Into<Option<&'a TlsInteraction>>, Q: Into<Option<&'b Cancellable>>>(&self, issuer_raw_dn: /*Ignored*/&glib::ByteArray, interaction: P, flags: TlsDatabaseLookupFlags, cancellable: Q) -> Result<Vec<TlsCertificate>, Error>;


Hm why is this not using a GBytes? Should probably add bindings for GByteArray at some point :)

sdroege · 2018-02-17T09:44:26Z

src/auto/tls_interaction.rs

+    fn request_certificate<'a, P: IsA<TlsConnection>, Q: Into<Option<&'a Cancellable>>>(&self, connection: &P, flags: TlsCertificateRequestFlags, cancellable: Q) -> Result<TlsInteractionResult, Error>;
+
+    #[cfg(any(feature = "v2_40", feature = "dox"))]
+    fn request_certificate_async<'a, P: IsA<TlsConnection>, Q: Into<Option<&'a Cancellable>>, R: FnOnce(Result<(), Error>) + Send + 'static>(&self, connection: &P, flags: TlsCertificateRequestFlags, cancellable: Q, callback: R);


Same problem with the async function, probably various others elsewhere too

sdroege · 2018-02-17T09:48:14Z

src/auto/tls_connection.rs

+use std::ptr;
+
+glib_wrapper! {
+    pub struct TlsConnection(Object<ffi::GTlsConnection, ffi::GTlsConnectionClass>): IOStream;


While we're at it, this is useless without GTlsClientConnection and/or GTlsServerConnection. Both of which look trivially autogenerateable :)

MathieuDuponchelle · 2018-02-20T15:39:01Z

Proposed #85 , will update this PR after we have merged it

sdroege · 2018-02-21T19:41:14Z

src/auto/tls_client_connection.rs

+    #[cfg(any(feature = "v2_46", feature = "dox"))]
+    fn copy_session_state<P: IsA<TlsClientConnection>>(&self, source: &P);
+
+    //fn get_accepted_cas(&self) -> /*Ignored*/Vec<glib::ByteArray>;


Another byte array instead of GBytes, how weird

sdroege · 2018-02-21T19:43:56Z

Looks all good to me, but the byte array stuff annoys me. I don't think we can safely wrap that in Rust because it's refcounted and any other user of it could cause reallocation of the memory area that we might borrow currently... this should really be GBytes in the C API.

sdroege · 2018-02-22T10:15:34Z

Let's get it in then? And those bytearray functions should imho just be manually implemented and then use a GBytes

GuillaumeGomez · 2018-02-22T10:20:58Z

Then let's go for it! Thanks everyone!

sdroege · 2018-02-23T11:48:43Z

Something went wrong here: https://travis-ci.org/sdroege/gstreamer-rs/jobs/345089461

TlsAuthenticationMode is not generated anymore, and basically all the TLS types are missing from the Gir.toml now except for two.

sdroege · 2018-02-23T11:48:48Z

@MathieuDuponchelle

EPashkin · 2018-02-23T12:17:09Z

Also files like auto/tls_server_connection.rs still included but not added to auto/mod.rs

EPashkin · 2018-02-23T12:22:56Z

List of not generated files:

src/auto/tls_client_connection.rs
src/auto/tls_connection.rs
src/auto/tls_database.rs
src/auto/tls_interaction.rs
src/auto/tls_password.rs
src/auto/tls_server_connection.rs

sdroege · 2018-02-23T12:31:44Z

Yes, the Gir.toml changes disappeared from the PR at some point

MathieuDuponchelle · 2018-02-23T14:55:18Z

How weird, I have 4 files neatly unstaged here, not sure why!

More tls bindings

MathieuDuponchelle force-pushed the more_tls_bindings branch from 3a74b62 to 06afc08 Compare February 17, 2018 02:42

EPashkin reviewed Feb 17, 2018

View reviewed changes

sdroege reviewed Feb 17, 2018

View reviewed changes

Add more Tls bindings

23e091d

MathieuDuponchelle force-pushed the more_tls_bindings branch from 06afc08 to 23e091d Compare February 21, 2018 18:04

sdroege reviewed Feb 21, 2018

View reviewed changes

GuillaumeGomez merged commit 9698ac7 into gtk-rs:master Feb 22, 2018

MathieuDuponchelle mentioned this pull request Feb 23, 2018

More Tls bindings: missing files #87

Merged

vhdirk pushed a commit to vhdirk/gio-rs that referenced this pull request Jan 16, 2019

Merge pull request gtk-rs#83 from MathieuDuponchelle/more_tls_bindings

0c22f25

More tls bindings

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More tls bindings #83

More tls bindings #83

MathieuDuponchelle commented Feb 17, 2018

EPashkin Feb 17, 2018

MathieuDuponchelle Feb 21, 2018

EPashkin commented Feb 17, 2018

sdroege Feb 17, 2018

MathieuDuponchelle Feb 18, 2018

sdroege Feb 20, 2018

MathieuDuponchelle Feb 21, 2018

sdroege Feb 17, 2018

MathieuDuponchelle Feb 21, 2018

sdroege Feb 17, 2018

MathieuDuponchelle Feb 21, 2018

sdroege Feb 17, 2018

MathieuDuponchelle Feb 21, 2018

MathieuDuponchelle commented Feb 20, 2018

sdroege Feb 21, 2018

sdroege commented Feb 21, 2018

sdroege commented Feb 22, 2018

GuillaumeGomez commented Feb 22, 2018

sdroege commented Feb 23, 2018

sdroege commented Feb 23, 2018

EPashkin commented Feb 23, 2018 •

edited

Loading

EPashkin commented Feb 23, 2018

sdroege commented Feb 23, 2018

MathieuDuponchelle commented Feb 23, 2018


		fn lookup_certificate_for_handle<'a, 'b, P: Into<Option<&'a TlsInteraction>>, Q: Into<Option<&'b Cancellable>>>(&self, handle: &str, interaction: P, flags: TlsDatabaseLookupFlags, cancellable: Q) -> Result<Option<TlsCertificate>, Error>;

		fn lookup_certificate_for_handle_async<'a, 'b, P: Into<Option<&'a TlsInteraction>>, Q: Into<Option<&'b Cancellable>>, R: FnOnce(Result<(), Error>) + Send + 'static>(&self, handle: &str, interaction: P, flags: TlsDatabaseLookupFlags, cancellable: Q, callback: R);


		fn lookup_certificate_issuer_async<'a, 'b, P: Into<Option<&'a TlsInteraction>>, Q: Into<Option<&'b Cancellable>>, R: FnOnce(Result<(), Error>) + Send + 'static>(&self, certificate: &TlsCertificate, interaction: P, flags: TlsDatabaseLookupFlags, cancellable: Q, callback: R);

		//fn lookup_certificates_issued_by<'a, 'b, P: Into<Option<&'a TlsInteraction>>, Q: Into<Option<&'b Cancellable>>>(&self, issuer_raw_dn: /Ignored/&glib::ByteArray, interaction: P, flags: TlsDatabaseLookupFlags, cancellable: Q) -> Result<Vec<TlsCertificate>, Error>;

More tls bindings #83

More tls bindings #83

Conversation

MathieuDuponchelle commented Feb 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EPashkin commented Feb 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MathieuDuponchelle commented Feb 20, 2018

Choose a reason for hiding this comment

sdroege commented Feb 21, 2018

sdroege commented Feb 22, 2018

GuillaumeGomez commented Feb 22, 2018

sdroege commented Feb 23, 2018

sdroege commented Feb 23, 2018

EPashkin commented Feb 23, 2018 • edited Loading

EPashkin commented Feb 23, 2018

sdroege commented Feb 23, 2018

MathieuDuponchelle commented Feb 23, 2018

EPashkin commented Feb 23, 2018 •

edited

Loading