This repository was archived by the owner on Jun 8, 2021. It is now read-only.
Remove missed callback_guard #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, seems all rt.rs need removing |
|
Or better leave with |
|
We should really move all the macros inside a common crate. It'd make such things simpler. Anyway, if they're not used, just remove them. |
EPashkin
force-pushed
the
remove_callback_guard
branch
from
1462bd8 to
2879974
Compare
|
Updated. Moving to common crates IMHO impossible as these macros has different meaning in all your crates. |
|
Single travis failure again. |
|
But no printing for 10min still strange, maybe it some infrastructure problem. |
|
I think so. Let's merge. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of gtk-rs/glib#250
Forgot some manual calls
@GuillaumeGomez