Fix template rendering for skip files and engines #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
approved these changes
Oct 12, 2021
| rawMatchedPaths, err := zglob.Glob(globPath) | ||
| if err != nil { | ||
| // TODO: logger-debug - switch to debug | ||
| util.Logger.Printf("ERROR: could not glob %s", globPath) |
There was a problem hiding this comment.
We don't have logging levels implemented in boilerplate yet. This is a tag to help us track which ones we want to convert to debug logs when we implement it.
I thought we had an issue already for this, but filed a new one #82
|
Thanks for review! Will merge this as I need this in the feature I'm working on right now in architecture catalog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pathandnot_pathattributes forskip_filesandengineswas not being rendered through boilerplate templating, when we want it to support that.As a bonus, this adds more logging on
globfailures so it is easier to understand what is going on. Otherwise, you get an unhelpful error message that simply statesfile does not exist.