Builtin pow (from Add pow builtin ) #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r21gh
reviewed
Oct 8, 2018
| func builtinPower(f *Frame, args Args, kwargs KWArgs) (*Object, *BaseException) { | ||
| argc := len(args) | ||
| expectedTypes := []*Type{ObjectType, ObjectType} | ||
| if argc == 3 { |
There was a problem hiding this comment.
length will be cached and there is no overhead
for better performance we can remove argc initialization.
There was a problem hiding this comment.
you want to replace with if argc = len(args) { ?
There was a problem hiding this comment.
no.
just using len(args), instead of declaring and initializing argc.
func builtinPower(f *Frame, args Args, kwargs KWArgs) (*Object, *BaseException) { expectedTypes := []*Type{ObjectType, ObjectType} if argc == len(args) {
It's not a problem @alanjds , It's just for more performance.
There was a problem hiding this comment.
Done on 0a11050.
Waiting to merge.
|
Why are our builds failing ever with working code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased from google#373 over #92