[14.0][IMP] purchase_ivoice_plan, non-editable installment

purchase_invoice_plan/__manifest__.py

@@ -12,6 +12,7 @@
     "depends": ["purchase_open_qty", "purchase_stock"],
     "data": [
         "security/ir.model.access.csv",
+        "data/purchase_data.xml",
         "wizard/purchase_create_invoice_plan_view.xml",
         "wizard/purchase_make_planned_invoice_view.xml",
         "views/purchase_view.xml",

purchase_invoice_plan/data/purchase_data.xml

@@ -0,0 +1,6 @@
+<odoo noupdate="1">
+    <record id="decimal_price" model="decimal.precision" forcecreate="True">
+        <field name="name">Purchase Invoice Plan Percent</field>
+        <field name="digits">6</field>
+    </record>
+</odoo>

purchase_invoice_plan/models/purchase.py

@@ -16,8 +16,6 @@ class PurchaseOrder(models.Model):
         inverse_name="purchase_id",
         string="Invoice Plan",
         copy=False,
-        readonly=True,
-        states={"draft": [("readonly", False)]},
     )
     use_invoice_plan = fields.Boolean(
         string="Use Invoice Plan",
@@ -52,6 +50,14 @@ def _compute_ip_invoice_plan(self):
                 and len(rec.invoice_plan_ids.filtered(lambda l: not l.invoiced))
             )
 
+    @api.constrains("invoice_plan_ids")
+    def _check_ip_total_percent(self):
+        for rec in self:
+            installments = rec.invoice_plan_ids.filtered("installment")
+            ip_total_percent = sum(installments.mapped("percent"))
+            if float_round(ip_total_percent, 0) > 100:
+                raise UserError(_("Invoice plan total percentage must not exceed 100%"))
+
     @api.constrains("state")
     def _check_invoice_plan(self):
         for rec in self:
@@ -73,7 +79,7 @@ def create_invoice_plan(
         self.invoice_plan_ids.unlink()
         invoice_plans = []
         Decimal = self.env["decimal.precision"]
-        prec = Decimal.precision_get("Product Unit of Measure")
+        prec = Decimal.precision_get("Purchase Invoice Plan Percent")
         percent = float_round(1.0 / num_installment * 100, prec)
         percent_last = 100 - (percent * (num_installment - 1))
         for i in range(num_installment):
@@ -171,7 +177,7 @@ class PurchaseInvoicePlan(models.Model):
     )
     percent = fields.Float(
         string="Percent",
-        digits="Product Unit of Measure",
+        digits="Purchase Invoice Plan Percent",
         help="This percent will be used to calculate new quantity",
     )
     amount = fields.Float(
@@ -201,6 +207,9 @@ class PurchaseInvoicePlan(models.Model):
         help="If this line already invoiced",
         store=True,
     )
+    no_edit = fields.Boolean(
+        compute="_compute_no_edit",
+    )
 
     @api.depends("percent")
     def _compute_amount(self):
@@ -256,6 +265,14 @@ def _compute_last(self):
             last = max(rec.purchase_id.invoice_plan_ids.mapped("installment"))
             rec.last = rec.installment == last
 
+    def _no_edit(self):
+        self.ensure_one()
+        return self.invoiced
+
+    def _compute_no_edit(self):
+        for rec in self:
+            rec.no_edit = rec._no_edit()
+
     def _compute_new_invoice_quantity(self, invoice_move):
         self.ensure_one()
         if self.last:  # For last install, let the system do the calc.
@@ -284,3 +301,16 @@ def _update_new_quantity(self, line, percent):
     def _get_plan_qty(self, order_line, percent):
         plan_qty = order_line.product_qty * (percent / 100)
         return plan_qty
+
+    def unlink(self):
+        lines = self.filtered("no_edit")
+        if lines:
+            installments = [str(x) for x in lines.mapped("installment")]
+            raise UserError(
+                _(
+                    "Installment %s: already used and not allowed to delete.\n"
+                    "Please discard changes."
+                )
+                % ", ".join(installments)
+            )
+        return super().unlink()

purchase_invoice_plan/views/purchase_view.xml

@@ -4,11 +4,29 @@
         <field name="model">purchase.invoice.plan</field>
         <field name="arch" type="xml">
             <tree editable="bottom">
-                <field name="installment" />
-                <field name="plan_date" />
-                <field name="invoice_type" />
-                <field name="percent" optional="show" />
-                <field name="amount" optional="show" />
+                <field name="no_edit" invisible="1" />
+                <field
+                    name="installment"
+                    attrs="{'readonly': [('no_edit', '=', True)]}"
+                />
+                <field
+                    name="plan_date"
+                    attrs="{'readonly': [('no_edit', '=', True)]}"
+                />
+                <field
+                    name="invoice_type"
+                    attrs="{'readonly': [('no_edit', '=', True)]}"
+                />
+                <field
+                    name="percent"
+                    optional="show"
+                    attrs="{'readonly': [('no_edit', '=', True)]}"
+                />
+                <field
+                    name="amount"
+                    optional="show"
+                    attrs="{'readonly': [('no_edit', '=', True)]}"
+                />
                 <field name="to_invoice" />
                 <field name="invoiced" />
                 <field name="invoice_ids" optional="hide" widget="many2many_tags" />
@@ -85,7 +103,7 @@
                     <field
                         name="invoice_plan_ids"
                         context="{'tree_view_ref': 'view_purchase_invoice_plan_tree'}"
-                        attrs="{'invisible': [('invoice_plan_ids', '=', [])], 'readonly': [('invoice_count', '>', 0)]}"
+                        attrs="{'invisible': [('invoice_plan_ids', '=', [])]}"
                     />
                     <group class="oe_subtotal_footer oe_right">
                         <field name="ip_total_percent" />