-
Notifications
You must be signed in to change notification settings - Fork 430
Spelling #2250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Spelling #2250
Conversation
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this, a few of these changes are incorrect though.
Sources/GRPCCore/Streaming/Internal/BroadcastAsyncSequence.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCCoreTests/Call/Server/Internal/ServerRPCExecutorTests.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCCoreTests/Configuration/Generated/service_config.pb.swift
Outdated
Show resolved
Hide resolved
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Sorry, would you mind opening this against https://github.com/grpc/grpc-swift-2 instead? |
Sure. It won't be instant. I'm a human and have a day-job. Maybe the I know there's text in the readme: Lines 6 to 15 in 664cc40
But it didn't really help me. I actually first drafted a PR against 1.x and then decided to write one against |
This PR corrects misspellings identified by the check-spelling action
The misspellings have been reported at https://github.com/jsoref/grpc-swift/actions/runs/15731765094/attempts/1#summary-44334319115
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/grpc-swift/actions/runs/15731765292/attempts/1#summary-44334319714