compiler: add retry loop and enable allowEmptyChecksums on Windows - #12962
Merged
Conversation
Enables allowEmptyChecksums globally on Chocolatey and implements a 3-attempt retry loop for pkgconfiglite to prevent Windows CI failures caused by transient network or SourceForge mirror errors. Even though --allow-empty-checksums is passed to choco install, newer Chocolatey versions do not propagate this CLI flag to the nested PowerShell installer script (chocolateyInstall.ps1). The inner script fails when downloading the binary from non-secure HTTP SourceForge mirrors unless the allowEmptyChecksums feature is globally enabled via choco feature beforehand.
shivaspeaks
reviewed
Aug 3, 2026
| @@ -1,4 +1,20 @@ | |||
| choco feature enable -n allowEmptyChecksums | |||
Member
There was a problem hiding this comment.
Since this modifies the global Chocolatey state, do we need to disable it (choco feature disable -n allowEmptyChecksums) after the installation finishes? Or is it safe to leave it permanently enabled?
|
|
||
| set RETRY=0 | ||
| :install_pkgconfig | ||
| choco install -y pkgconfiglite --allow-empty-checksums |
Member
There was a problem hiding this comment.
--allow-empty-checksums this flag becomes redundant because it is enabled globally?
| ping -n 6 127.0.0.1 >nul | ||
| goto :install_pkgconfig | ||
| ) | ||
| echo Failed to install pkgconfiglite after 3 attempts. |
Member
There was a problem hiding this comment.
We should either loop 2 times for this statement to hold true. Or we can say here-
echo Failed to install pkgconfiglite after 4 attempts.
Member
|
Is there a way to run Windows CI with this updated file and paste the link here? |
shivaspeaks
approved these changes
Aug 3, 2026
…p to guarantee a clean retry, recovering correctly if previous attempts left the package in a broken half-installed state. Introduces a reusable ':RunPowershellWithRetry' helper to automatically re-attempt PowerShell 'Invoke-WebRequest' downloads (Protobuf, Abseil, CMake) when GitHub or connection timeouts occur."
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables allowEmptyChecksums globally on Chocolatey and implements a 3-attempt retry loop for pkgconfiglite to prevent Windows CI failures caused by transient network or SourceForge mirror errors. Even though --allow-empty-checksums is passed to choco install, newer Chocolatey versions do not propagate this CLI flag to the nested PowerShell installer script (chocolateyInstall.ps1). The inner script fails when downloading the binary from non-secure HTTP SourceForge mirrors unless the allowEmptyChecksums feature is globally enabled via choco feature beforehand.
This change also makes the script exit prematurely if pkg-config installation still failed instead of continuing and failing later at the linking step.
Failed Kokoro build logs example.