Update trackingCallback with user argument - #112
Open
teresayung wants to merge 2 commits into
Open
Conversation
added 2 commits
July 30, 2026 19:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward
userarg through the patched tracking callbackThe content script's
setTrackingCallbackpatch dropped the callback's third arg, so consumers gotuser === undefined. The SDK calls tracking callbacks with(experiment, result, user), whereuseris the attribute snapshot at evaluation time.This updates the wrapper in
embed_script.tsto accept and forward an optionaluser?: UserContext, and to include it in the object pushed tosetDeferredTrackingCalls({ experiment, result, user }).useris optional throughout, so it flows through safely asundefinedwhen the page SDK doesn't supply one.isNoopCallback/originalParamshandling is unchanged.Preserving this exact arg matters because reading live attributes instead would drift for deferred tracking calls.
Note: the pinned SDK (
1.6.5) predates the 3-arg signature, so a small localTrackingCallbackWithUsertype and anas TrackingDatacast are used to compile; both can be dropped once the SDK is bumped.