Skip to content

Prevent proxy credential leakage from URL parse errors - #1732

Draft
groupthinking with Copilot wants to merge 2 commits into
mainfrom
copilot/groupthinking-fix-proxy-credential-leakage-and-vac
Draft

Prevent proxy credential leakage from URL parse errors#1732
groupthinking with Copilot wants to merge 2 commits into
mainfrom
copilot/groupthinking-fix-proxy-credential-leakage-and-vac

Conversation

Copilot AI commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Canonical issue

Outcome

Malformed proxy URLs no longer propagate credential-bearing parse errors, and yt-dlp/transcript failure logs redact proxy userinfo.

Scope

  • Included:
    • Validate proxy ports and supported schemes consistently across canonical and standalone helpers.
    • Sanitize transcript, yt-dlp, Whisper, and metadata failure details before logging or returning them.
    • Add regression coverage for malformed URLs, socks5h, helper parity, and credential redaction.
  • Explicitly excluded:
    • Broader refactoring of unrelated error logging paths.
    • Production deployment changes.

Example:

try:
    parsed = urllib.parse.urlparse(url)
    valid = parsed.scheme in _ALLOWED_SCHEMES and bool(parsed.hostname)
    if valid:
        _ = parsed.port
except ValueError:
    valid = False

Risk

  • Risk level: low
  • Failure mode: Invalid proxy configuration falls back to direct connection; diagnostic details remain redacted.
  • Rollback: Revert commit 464a68faa5f914687f4057d097341322e9703518.

Verification

Current head: 464a68faa5f914687f4057d097341322e9703518

  • Focused tests: python -m pytest -q --no-cov tests/unit/test_proxy_utils.py — 45 passed
  • Required CI — pending/action required
  • Review threads resolved

Production evidence

Not applicable; this change affects validation and logging behavior only.

Agent handoff

  • One canonical issue is linked
  • No competing PR implements the same issue
  • Acceptance criteria are satisfied
  • Required checks pass on the current head
  • Human decision is requested only for product, security, irreversible infrastructure, or production approval

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Sep 8, 2026 11:23pm UTC

Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix proxy credential leakage from urlparse errors Prevent proxy credential leakage from URL parse errors Sep 8, 2026
Copilot AI requested a review from groupthinking September 8, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent proxy credential leakage from urlparse errors

2 participants