Sanitize v1 router log inputs - #1726
Draft
groupthinking with Copilot wants to merge 3 commits into
Draft
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
9 tasks
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Sanitize v1 router log inputs to prevent CR/LF log forging
Sanitize v1 router log inputs
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical issue
Linked by issue metadata.
Outcome
Prevents CR/LF log forging from v1-router dynamic log values while preserving diagnostic context.
Scope
_safe_log_value()for single-line log-safe rendering.Risk
Verification
Current head:
d36b30415fba8ea9cf0392859d83a68019c7c379pytest tests/unit/test_v1_router_extended.py -q --no-cov→146 passed, 2 warningsaction_requiredbefore jobs are created; no failed-job logs available.Production evidence
Not applicable: this changes Python backend logging and unit tests only; no frontend or deployment surface changed.
Agent handoff