Skip to content

Optimize transcript no-filter search path - #1723

Open
groupthinking with Copilot wants to merge 2 commits into
mainfrom
copilot/bolt-optimize-interactive-transcript-4719841486477
Open

Optimize transcript no-filter search path#1723
groupthinking with Copilot wants to merge 2 commits into
mainfrom
copilot/bolt-optimize-interactive-transcript-4719841486477

Conversation

Copilot AI commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Canonical issue

Linked automatically.

Outcome

Transcript filtering now avoids allocation when no search or speaker filter is active, while preserving null/empty-query behavior and one-time query normalization.

if (!search && !speaker) return segments as TranscriptSegment[];

Scope

  • Included:
    • No-filter fast path in filterSegments
    • Regression coverage for preserving original segment identity
  • Explicitly excluded:
    • UI changes
    • Workflow/provenance gate changes
    • Unrelated billing/type-check fixes

Risk

  • Risk level: low
  • Failure mode: filtered transcript list could skip allocation but return stale references only when callers mutate segment arrays unexpectedly
  • Rollback: remove the early return and the matching identity assertion

Verification

Current head: 56c6c06707c41e9e50d39150f09c782cb60e4008

  • Focused tests: npm test --workspace apps/web -- src/lib/__tests__/transcript-search.test.ts
  • Required CI
  • Review threads resolved

Production evidence

Not applicable yet; this is a pure transcript-filter helper change. Preview/runtime evidence should attach to the current head if repository governance requires web deployment proof.

Agent handoff

  • One canonical issue is linked
  • No competing PR implements the same issue
  • Acceptance criteria are satisfied
  • Required checks pass on the current head
  • Human decision is requested only for product, security, irreversible infrastructure, or production approval

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Sep 8, 2026 10:53pm UTC

Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot AI changed the title [WIP] Optimize transcript search allocation for better performance Optimize transcript no-filter search path Sep 8, 2026
Copilot AI requested a review from groupthinking September 8, 2026 22:55
@github-actions

Copy link
Copy Markdown
Contributor

🔍 PR Validation

⚠️ PR title should follow conventional commits format

@github-actions github-actions Bot added javascript Pull requests that update javascript code tests labels Sep 12, 2026
@groupthinking
groupthinking marked this pull request as ready for review September 12, 2026 08:18
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 78d15f73-f768-4654-ad9c-79e0d5779145

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 56c6c06.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@groupthinking groupthinking added the bug Something isn't working label Sep 12, 2026
@cursor

cursor Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Backlog triage: leaving open. Transcript search allocation (#908) is CONFLICTING vs rewritten main. Rebase + core-green required.

@groupthinking
groupthinking enabled auto-merge (squash) September 12, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working javascript Pull requests that update javascript code tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Execution: optimize transcript search allocation (PR #897)

2 participants