fix(security): SSRF-safe cloud callbacks with pinned DNS and log sanitization - #1686
Draft
linear-code[bot] wants to merge 1 commit into
Draft
fix(security): SSRF-safe cloud callbacks with pinned DNS and log sanitization#1686linear-code[bot] wants to merge 1 commit into
linear-code[bot] wants to merge 1 commit into
Conversation
…tization Recreate the PR #734 hardening on a fresh main-based branch: resolve callback hosts once off-loop, reject non-global/mixed DNS answers, pin connections to validated numeric addresses (preserving Host/SNI/hostname verification and disabled redirects), bound dispatch to three addresses under one deadline without retrying a transmitted POST, and CR/LF-sanitize untrusted callback and exception log values. Generated with [Linear](https://linear.app/myxstack/agent-session/f979788e-1a9c-463c-8f45-146d3c1ec52e) Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
Contributor
Author
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔍 PR Validation |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| f"(async={request.async_processing}, priority={request.priority})" | ||
| "🎬 Cloud processing request: %s (async=%s, priority=%s)", | ||
| _sanitize_log_value(request.video_url), | ||
| request.async_processing, |
| "🎬 Cloud processing request: %s (async=%s, priority=%s)", | ||
| _sanitize_log_value(request.video_url), | ||
| request.async_processing, | ||
| request.priority, |
groupthinking
added
high-priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreates the PR #734 cloud-callback hardening on a fresh branch cut from current
main, so the change carries clean provenance (the original PR is blocked only by its historical pre-dispatch boundary, not by code issues).Changes to
src/youtube_extension/backend/cloud_api_endpoints.py(+ tests intests/unit/test_cloud_routes.py):The PR #734 diff was applied onto current
mainwith a 3-way merge; the intervening #1361 change (Cloud Tasks auth before payload validation) is preserved alongside the hardening. Note: the session was cut off before the focused suite (tests/unit/test_cloud_routes.py) could run in this environment — please rely on CI for verification. The same diff passed CI, Coverage, CodeQL, Security/Secret scans, Dependency Review, and CodeRabbit review at PR #734's head (122 focused tests passed there).