Use \parshape for multiline initials #1608
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h as the line, so that \wrapfigure or \parshape can be used.
davidweichiang
commented
Feb 1, 2025
tex/gregoriotex-main.tex
Outdated
| \gre@hskip\gre@dimen@temp@four % | ||
| \global\advance\gre@dimen@initialwidth by \gre@dimen@temp@four % | ||
| \gre@debugmsg{annotation}{Ready to place initial.}% | ||
| \ifgre@showlyrics% | ||
| \box\gre@box@initial% | ||
| \smash{\box\gre@box@initial}% |
There was a problem hiding this comment.
The \smash is presumably what's changing the appearance of initials with descenders.
There was a problem hiding this comment.
I don't remember why the \smash was there. It seems to make no difference now...
davidweichiang
commented
Feb 1, 2025
| @@ -678,7 +575,10 @@ | |||
| %% has to be called before drawing the key, after drawing the initial | |||
| \def\gre@beginnotes{% | |||
| \gre@trace{gre@beginnotes}% | |||
| \gre@drawfirstlines % | |||
| % Draw the staff lines the same as the other staves; post_linebreak | |||
| % will fix them. The \hbox is there so that post_linebreak can find | |||
There was a problem hiding this comment.
This is a hack. It would be better either to mark the initial with an attribute, or to draw all the lines using \localleftbox (I couldn't figure out how).
davidweichiang
commented
Feb 1, 2025
| @@ -392,7 +392,7 @@ | |||
| \gre@trace{GreSetInitialClef{#1}{#2}{#3}{#4}{#5}{#6}{#7}}% | |||
| \gre@save@clef{#1}{#2}{#3}{#4}{#5}{#6}% | |||
| \ifgre@showclef% | |||
| \ifnum\gre@initiallines=1\relax % | |||
| \ifnum\gre@count@initiallines>0\relax % | |||
There was a problem hiding this comment.
I was unsure why this was =1 but am just as unsure whether changing it to >0 made any sense.
davidweichiang
commented
Feb 1, 2025
| @@ -435,7 +435,7 @@ | |||
| \gre@debugmsg{bolshift}{ clefwidthcurrent = \the\gre@dimen@clefwidth@current}% | |||
| \gre@debugmsg{bolshift}{ clefwidthbol = \the\gre@dimen@clefwidth@bol}% | |||
| % we ignore the current-bol adjustment if the clef is the first of the score and there is an initial on one line: | |||
| \ifnum\gre@initiallines=1\ifgre@beginningofscore\else % | |||
| \ifnum\gre@count@initiallines>0\ifgre@beginningofscore\else % | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses \parshape to indent the first k lines, then
post_linebreak_filterto change the width of the staff lines.