Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored hyphen macros. #1161

Closed
wants to merge 1 commit into from

Conversation

henryso
Copy link
Contributor

@henryso henryso commented Jun 24, 2016

Fixes #1140.

No tests change.

Please review and merge if satisfactory.

@henryso henryso added the TeX label Jun 24, 2016
@henryso henryso added this to the 4.2 milestone Jun 24, 2016
@henryso henryso self-assigned this Jun 24, 2016
@eroux
Copy link
Contributor

eroux commented Jun 25, 2016

Thanks, I think it's a good basis! But the main point for this feature is to allow the user to change the hyphen (font+char) according to the space the hyphen has... So I think it would be helpful to have a high level macro doing this (redefining \gre@hyphen in fact) a difficulty is to allow the user to change the hyphen automatically added in the Lua pass... Do you see what I mean? (I'm not sure it's 100% clear in my head)

@eroux
Copy link
Contributor

eroux commented Jun 25, 2016

In fact, in an ideal world, the second argument of \gre@hyphen would not be ignored in the case of hyphens added by Lua at the and of a line, it would be enddifference+width of (custos+space)... That requires the eolshift code to tell Lua which hyphen should be used though, but that could be done with an attribute... Wdyt?

@henryso
Copy link
Contributor Author

henryso commented Jun 25, 2016

I honestly don't know enough about this stuff to comment in any meaningful way. Let me know what I should do and I'll try to do it.

@eroux
Copy link
Contributor

eroux commented Jun 25, 2016

Hmmm... it's a bit blur in my mind too... maybe I can just continue the PR ? I have a few ideas on how to do what I think would be best...

@henryso
Copy link
Contributor Author

henryso commented Jun 25, 2016

Ok, I will pull this change into its own branch.

@henryso henryso closed this Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants