-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to print only the first flat on each line #357
base: develop
Are you sure you want to change the base?
Add option to print only the first flat on each line #357
Conversation
If I'm understanding the Dominican convention correctly, then the the notes at the
Applying the same rules to the right-hand score and organizing everything into a table gives me the following:
Have I understood and applied the Dominican rule appropriately? If so, this is a good test with several syllables showing a discrepancy between the two scores. What would be most useful is a list of the "correct" choice. The gabc should show this (by explicitly including the |
That's right. I've updated the test to include the score as it was originally printed. I am not sure why the Ma in Mater has an explicit flat. As I understand it, it wasn't really needed. |
Okay, I understand the test now and think it looks good. My only remaining quibble is with calling the note "B" since square notes are technically a moveable do system and thus don't map to exact pitches. But as I said, it's a quibble and doesn't really affect the understanding of the tests so I wouldn't change it. This test is a bit different in that one document shows both failing test and the passing test, but that's because the underlying gabc is different in these two cases. I think that's a good reason for leaving this as is. |
Illustrates gregorio-project/gregorio#157.
Goes with gregorio-project/gregorio#1607.