-
Notifications
You must be signed in to change notification settings - Fork 930
Allow for accessing nested object data. #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can we merge this? the conflict is in the package-lock.json file and those changes are only on optional flags. |
We can't merge this until the conflicts are resolved, but it also needs review, which I will provide when I have the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice, and looks like a highly requested feature.
I think we just need to clean up the edge case where we have improper/missing paths.
Also would be great to have a test for this, if you've got the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the undefined check! I will attempt a test before next release, but this looks good for merge.
@epavan I need more information to debug your code (in particular, the actual code). Make sure you are using this feature as indicated in the example |
This PR allows for the use of dot notation in the column names to access nested object data.
For instance, the modified example adds a phone object to each existing user and each phone has a "home" and "cell" attribute. These nested attributes can be accessed with a column name of "phone.home" and "phone.cell", respectively.
Any amount of nested will work with this.
This addresses #147, #531, and (I think) #475.