Implement bundle with babel core-js@3 #1553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add @babel/runtime-corejs3 - add core-js
wdh2100
commented
Oct 21, 2020
|
|
||
| var returnHomeStyle = { padding: '0px', margin: '20px 0 20px 0' }; | ||
|
|
||
| return ( |
There was a problem hiding this comment.
as-is
return <main>
....
</main>to-be
return (
<main
...
</main>
)|
|
||
| // get data | ||
| getData = (url, page) => { | ||
| getData = async (url, page) => { |
| "sinon": "^7.4.2", | ||
| "style-loader": "^1.2.1", | ||
| "webpack": "^4.43.0", | ||
| "webpack-cli": "^3.3.11", |
There was a problem hiding this comment.
Move package (dev)
Comment on lines
+44
to
+45
| "@babel/plugin-transform-async-to-generator": "^7.12.1", | ||
| "@babel/plugin-transform-runtime": "^7.12.1", |
| "react-dom": "^16.8.0" | ||
| }, | ||
| "dependencies": { | ||
| "@babel/runtime-corejs3": "^7.12.1", |
| module.exports = { | ||
| entry: { | ||
| app: "./examples/Router/index.js" | ||
| app: ['core-js/stable', 'regenerator-runtime/runtime', './examples/Router/index.js'], |
| "settings": { | ||
| "import/extensions": [".js"], | ||
| "react": { | ||
| "version": "latest" |
Comment on lines
+46
to
+51
| "@babel/plugin-transform-runtime", | ||
| { | ||
| "corejs": 3, | ||
| "regenerator": true | ||
| } | ||
| ] |
Comment on lines
+14
to
+27
| "browsers": [ | ||
| "ie >= 11", | ||
| "> 1%", | ||
| "iOS >= 8", | ||
| "Android >= 4" | ||
| ], | ||
| "node": "6.10" | ||
| }, | ||
| "useBuiltIns": "usage", | ||
| "debug": false, | ||
| "modules": false, | ||
| "corejs": { | ||
| "version": 3, | ||
| "proposals": true |
|
I didn't get a chance to review this but hope to this coming week. Btw, did you see the email I sent you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added the process of inserting core-js during build and transpiling.
I want to show it as CodeSansBox, but CodeSandBox is not support IE
So you have to check it locally.
I've tested it in Chrome and IE.
Solved to fix this #835
I think... It seems to be insufficient, but there is no problem with the build and transpiling.
thanks!
ref :