Update react peer dependency ranges to include v19
#1019
Conversation
askoufis
changed the title
react peer dependency ranges to include v19
|
@theKashey Apologies for the tag. Would appreciate a review on this hopefully uncontroversial PR. Thank you in advance :) |
|
@askoufis @theKashey has this been validated as the only required fix for supporting React 19? My team is being impacted by this as we need to move to React 19. Is loadable abandoned and should I consider it deprecated? |
|
@gregberge curious in the absence of response from others if you know whether loadable should be considered abandoned / deprecated? It's impacting my team where we use it in an embedded runtime |
|
@gregberge @theKashey Would appreciate a review of this PR. It's only 3 lines and should be fairly straightforward. I'm not 100% certain that everything works with React 19, so happy put some more effort into increasing that certainty if it's of any concern. |
|
Time to fork?... |
For me this is mainly an optics issue. We maintain a CLI tool that scaffolds web applications. We depend on loadable-components, and would simply prefer not to have React 19 peer dependency warnings showing up during installation. I don't think it warrants a fork. |
|
@theKashey @gregberge Could you help us, plx! |
|
can we merge this please? |
Summary
Resolves #1014.
Appends
^19.0.0to thereactpeer dependencies in both the@loadable/componentand@loadable/serverpackages. I don't think there's anything about those package's usage ofreactthat would prevent React 19 from being compatible with them.Test plan
I struggled for a long time trying to get node v12 installed (via mise) as well as installing deps with
yarn. Having to install Python 2.x is a pain.Additionally, I had to replace a reference to what appears to be a private atlassian registry in the lockfile with a reference to the
yarnpkgregistry.After a while I gave up on node 12 and ran tests with node 16 (node 18 didn't work either) after manually executing parts of the
preparescript. All tests passed on my machine, though the repo is still using React 16 so the tests aren't really a guarantee that React 19 works. I didn't try updating the react dev deps to 19 for fear of more headaches, but happy to try it out if it's deemed necessary to merge this PR.Overall this was a very unpleasant contribution experience, though in fairness this repo doesn't exactly have regular contributions so it's understandable.