Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: New openvasd scanner type and relay fields #1212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timopollmeier
Copy link
Member

What

The latest GMP protocol version now supports the openvasd scanner type and the new scanner fields relay_host and relay_port.

Why

To be able to use the new scanner type and define relays for scanners.

References

GEA-987
The new optional relay fields require greenbone/gvmd/pull/2399

Checklist

  • Tests

The latest GMP protocol version now supports the openvasd scanner type
and the new scanner fields relay_host and relay_port.
@timopollmeier timopollmeier requested a review from a team as a code owner March 21, 2025 08:31
@greenbonebot greenbonebot enabled auto-merge (rebase) March 21, 2025 08:32
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA ea365e0.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 94.20290% with 8 lines in your changes missing coverage. Please review.

Project coverage is 97.64%. Comparing base (5ca766b) to head (ea365e0).

Files with missing lines Patch % Lines
gvm/protocols/gmp/requests/v226/_scanners.py 94.35% 6 Missing and 1 partial ⚠️
gvm/protocols/gmp/_gmp226.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1212      +/-   ##
==========================================
- Coverage   97.74%   97.64%   -0.10%     
==========================================
  Files          71       72       +1     
  Lines        4967     5105     +138     
  Branches      895      928      +33     
==========================================
+ Hits         4855     4985     +130     
- Misses         76       83       +7     
- Partials       36       37       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should increment the protocol version to 22.7. If we take it seriously this is a new feature and therefore requires a new minor version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants