Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Closed
09a3f3a to
57cc200
Compare
ozgen
reviewed
Mar 2, 2026
ozgen
reviewed
Mar 2, 2026
The container now renders/creates full nginx config files and not nginx templates anymore. This also has the advantage we can use sane defaults which don't need to be set as environment variables. Additionally our own nginx container image is used which supports auto reloading when a config file has changed.
Adapt the workflows to the new setup.
Adapt opening a browser window to new default settings.
Add examples in comments.
af53339 to
5b6cfc0
Compare
y0urself
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update Compose File for change nginx generation
Why
Despite not being able to reproduce the
host not found in upstreamerror the nginx config generation is changed in the gvm-config container. This PR adapts the compose file to the new config file generation.References
Closes #616