Skip to content

Update Compose File#617

Merged
greenbonebot merged 4 commits intomainfrom
compose-file
Mar 3, 2026
Merged

Update Compose File#617
greenbonebot merged 4 commits intomainfrom
compose-file

Conversation

@bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Feb 27, 2026

What

Update Compose File for change nginx generation

Why

Despite not being able to reproduce the host not found in upstream error the nginx config generation is changed in the gvm-config container. This PR adapts the compose file to the new config file generation.

References

Closes #616

@bjoernricks bjoernricks requested a review from a team as a code owner February 27, 2026 13:13
@bjoernricks bjoernricks marked this pull request as draft February 27, 2026 13:13
@greenbonebot greenbonebot enabled auto-merge (rebase) February 27, 2026 13:13
@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 5b6cfc0.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@srmo srmo mentioned this pull request Mar 2, 2026
@bjoernricks bjoernricks marked this pull request as ready for review March 2, 2026 11:50
@cfi-gb cfi-gb mentioned this pull request Mar 3, 2026
2 tasks
@bjoernricks bjoernricks requested a review from ozgen March 3, 2026 07:58
Copy link
Member

@ozgen ozgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

The container now renders/creates full nginx config files and not nginx
templates anymore. This also has the advantage we can use sane defaults
which don't need to be set as environment variables.

Additionally our own nginx container image is used which supports auto
reloading when a config file has changed.
Adapt opening a browser window to new default settings.
@greenbonebot greenbonebot merged commit dad447a into main Mar 3, 2026
4 checks passed
@greenbonebot greenbonebot deleted the compose-file branch March 3, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nginx doesn't start

4 participants