Skip to content

feat(view): added hook for opening files gallery #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged

Conversation

kseniya57
Copy link
Contributor

The hook for opening the files gallery from the yfm

@kseniya57 kseniya57 self-assigned this Apr 28, 2025
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@makhnatkin makhnatkin marked this pull request as draft April 28, 2025 13:16
@kseniya57 kseniya57 marked this pull request as ready for review May 6, 2025 16:31
@kseniya57 kseniya57 force-pushed the files-gallery branch 3 times, most recently from e95e8f8 to e3144f9 Compare May 7, 2025 11:36
Copy link
Collaborator

@makhnatkin makhnatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. return uikit peerDeps version plz
  2. rebase main plz and check screenshots tests

@kseniya57
Copy link
Contributor Author

  1. return uikit peerDeps version plz
  2. rebase main plz and check screenshots tests

I can't update the tests in the docker because of an error. Am I the only one with this problem?

➜  markdown-editor git:(files-gallery) ✗ npm run playwright:docker:update -g "should paste to code block without as is"

> @gravity-ui/[email protected] playwright:docker:update
> ./scripts/playwright-docker.sh 'npm run playwright:update' should paste to code block without as is

Trying to pull mcr.microsoft.com/playwright:v1.49.0-jammy...
Getting image source signatures
Copying blob sha256:9bc44a9ea3ce897b534d6312190ae77fcef2246b6a12f63ac48975e6a02c9988
Copying blob sha256:4be1db8bbbebdd00e047c599d9aa2ee2ac533600bee2ac25a86573e42598d326
Copying blob sha256:a6ef13bd9cd56b30eb38988a642c09827d1f718e58abde1f8dc71f2f996db43b
Copying blob sha256:c16b1d11d19da039a2d829473890fe3841ab80e7862df18db8589ba18f021ae1
Copying config sha256:fc9eb578b6c23b896ebf37e167bfec339dc5ae61bea1a1aee6c56591406eb64c
Writing manifest to image destination

> @gravity-ui/[email protected] playwright:update
> npm run playwright -- -u should paste to code block without as is


> @gravity-ui/[email protected] playwright
> playwright test --config=tests/playwright/playwright.config.ts -u should paste to code block without as is


Running 102 tests using 2 workers

vite v5.4.15 building for production...

(!) outDir /work/tests/playwright/.cache-docker is not inside project root and will not be emptied.
Use --emptyOutDir to override.

[plugin:vite:resolve] [plugin vite:resolve] Module "fs" has been externalized for browser compatibility, imported by "/work/node_modules/css/lib/stringify/source-map-support.js". See https://vite.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] [plugin vite:resolve] Module "path" has been externalized for browser compatibility, imported by "/work/node_modules/css/lib/stringify/source-map-support.js". See https://vite.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] [plugin vite:resolve] Module "path" has been externalized for browser compatibility, imported by "/work/node_modules/css/node_modules/source-map-resolve/index.js". See https://vite.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] [plugin vite:resolve] Module "fs" has been externalized for browser compatibility, imported by "/work/node_modules/@diplodoc/transform/lib/utilsFS.js". See https://vite.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] [plugin vite:resolve] Module "path" has been externalized for browser compatibility, imported by "/work/node_modules/@diplodoc/transform/lib/utilsFS.js". See https://vite.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
node_modules/@storybook/core/dist/channels/index.js (1171:15): Use of eval in "node_modules/@storybook/core/dist/channels/index.js" is strongly discouraged as it poses security risks and may cause issues with minification.
node_modules/@storybook/core/dist/channels/index.js (1173:16): Use of eval in "node_modules/@storybook/core/dist/channels/index.js" is strongly discouraged as it poses security risks and may cause issues with minification.
node_modules/@diplodoc/folding-headings-extension/build/plugin/index.js (149:9): Use of eval in "node_modules/@diplodoc/folding-headings-extension/build/plugin/index.js" is strongly discouraged as it poses security risks and may cause issues with minification.
node_modules/@diplodoc/latex-extension/plugin/index.js (47:9): Use of eval in "node_modules/@diplodoc/latex-extension/plugin/index.js" is strongly discouraged as it poses security risks and may cause issues with minification.
node_modules/@diplodoc/mermaid-extension/plugin/index.js (47:9): Use of eval in "node_modules/@diplodoc/mermaid-extension/plugin/index.js" is strongly discouraged as it poses security risks and may cause issues with minification.
node_modules/@diplodoc/html-extension/build/plugin/index.js (39:9): Use of eval in "node_modules/@diplodoc/html-extension/build/plugin/index.js" is strongly discouraged as it poses security risks and may cause issues with minification.
node_modules/@diplodoc/cut-extension/build/plugin/index.js (171:9): Use of eval in "node_modules/@diplodoc/cut-extension/build/plugin/index.js" is strongly discouraged as it poses security risks and may cause issues with minification.
node_modules/@diplodoc/tabs-extension/build/plugin/index.js (193:9): Use of eval in "node_modules/@diplodoc/tabs-extension/build/plugin/index.js" is strongly discouraged as it poses security risks and may cause issues with minification.
node_modules/@diplodoc/transform/node_modules/@diplodoc/cut-extension/build/plugin/index.js (171:9): Use of eval in "node_modules/@diplodoc/transform/node_modules/@diplodoc/cut-extension/build/plugin/index.js" is strongly discouraged as it poses security risks and may cause issues with minification.
✓ 4964 modules transformed.
Killed
npm notice
npm notice New major version of npm available! 10.9.0 -> 11.3.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v11.3.0
npm notice To update run: npm install -g [email protected]
npm notice

@kseniya57 kseniya57 force-pushed the files-gallery branch 2 times, most recently from b30c939 to d3caa8b Compare May 13, 2025 12:04
@makhnatkin
Copy link
Collaborator

makhnatkin commented May 14, 2025

I can't update the tests in the docker because of an error. Am I the only one with this problem?
✓ 4964 modules transformed.
Killed

Try running npm run playwright:docker:clear first — it might help resolve the issue.

If the error persists, try reducing the number of workers from 2 to 1 in the config file:

workers: process.env.CI ? 2 : 2,

Also, consider increasing the memory limit here:

-e NODE_OPTIONS="--max-old-space-size=8192" \

Let me know if it helps!

@makhnatkin makhnatkin changed the title feat(YfmHtml): add a hook for opening files gallery feat(view): add a hook for opening files gallery May 15, 2025
@makhnatkin makhnatkin changed the title feat(view): add a hook for opening files gallery feat(view): added hook for opening files gallery May 15, 2025
@makhnatkin makhnatkin merged commit 622fdaa into main May 15, 2025
5 checks passed
@makhnatkin makhnatkin deleted the files-gallery branch May 15, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants