Skip to content

fix(Reactions): Changed Reactions buttons' pin to circle-circle #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
79e885e
fix: set 16px as border-radius for Reactions' buttons
Ruminat Dec 16, 2024
e804d78
fix: a better solution for rounding Reactions' buttons
Ruminat Dec 23, 2024
84caf8b
Merge remote-tracking branch 'origin/main' into fix-better-border-rad…
Ruminat Dec 23, 2024
1a76a52
fix: rename unstable namespace keyset (#253)
DarkGenius Dec 24, 2024
bfaee76
chore(main): release 3.13.2 (#254)
gravity-ui-bot Dec 24, 2024
279c9cb
chore: update codeowners (#257)
mournfulCoroner Jan 13, 2025
2a46c84
feat!: prepare v4 release (deps + removals) (#255)
amje Jan 13, 2025
49b04fc
feat: update uikit
amje Jan 13, 2025
7064db0
fix: lint issues
amje Jan 13, 2025
e7c1a27
feat!: major update Stories and StoriesGroup (#256)
DarkGenius Jan 14, 2025
90da3df
fix: bundling and tests
amje Jan 15, 2025
0d3b1b2
4.0.0-beta.0
amje Jan 15, 2025
bf872ec
feat!: use ts target es2022
amje Jan 15, 2025
d664744
4.0.0-beta.1
amje Jan 15, 2025
86dc20a
feat(ActionsPanel)!: remove component
amje Jan 16, 2025
c6fc0b9
4.0.0-beta.2
amje Jan 16, 2025
13ac887
feat!: update uikit
amje Jan 17, 2025
d1b01a7
4.0.0-beta.3
amje Jan 17, 2025
e20e6f3
fix: set 16px as border-radius for Reactions' buttons
Ruminat Dec 16, 2024
017a1ec
fix: a better solution for rounding Reactions' buttons
Ruminat Dec 23, 2024
ab0b661
fix(ConfirmDialog): focus on apply to submit on Enter
amje Jan 29, 2025
2cc2f1e
feat: update uikit
amje Jan 30, 2025
6e42cfa
4.0.0-beta.4
amje Jan 30, 2025
db190f7
fix: add exports field
amje Jan 30, 2025
b5beecd
4.0.0-beta.5
amje Jan 30, 2025
febaa45
feat: update uikit
amje Feb 4, 2025
a57ebb7
ci: update workflows actions
amje Feb 4, 2025
bf573a1
chore(main): release 4.0.0 (#259)
gravity-ui-bot Feb 4, 2025
237a300
fix: fix esm build (#260)
amje Feb 7, 2025
a726e03
chore(main): release 4.0.1 (#261)
gravity-ui-bot Feb 7, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .babelrc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@
}
],
"@babel/preset-typescript",
"@babel/preset-react"
[
"@babel/preset-react",
{
"runtime": "automatic"
}
]
],
"plugins": []
}
}
12 changes: 7 additions & 5 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,27 @@
"extends": [
"@gravity-ui/eslint-config",
"@gravity-ui/eslint-config/client",
"@gravity-ui/eslint-config/import-order",
"@gravity-ui/eslint-config/prettier",
"@gravity-ui/eslint-config/a11y"
"@gravity-ui/eslint-config/import-order",
"@gravity-ui/eslint-config/a11y",
"plugin:react/jsx-runtime"
],
"root": true,
"rules": {
"react/jsx-fragments": ["error", "element"],
"no-restricted-syntax": [
"error",
{
"selector": "ImportDeclaration[source.value='react'] :matches(ImportNamespaceSpecifier, ImportSpecifier)",
"message": "Please use import React from 'react' instead."
"selector": "ImportDeclaration[source.value='react'] :matches(ImportDefaultSpecifier, ImportSpecifier)",
"message": "Please use `import * as React from 'react'` instead."
},
{
"selector": "TSTypeReference>TSQualifiedName[left.name='React'][right.name='FC']",
"message": "Don't use React.FC"
}
],
"jsx-a11y/no-autofocus": 0
"jsx-a11y/no-autofocus": 0,
"import/no-extraneous-dependencies": 0
},
"overrides": [
{
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: npm
- name: Install Packages
run: npm ci
Expand All @@ -32,13 +32,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: npm
- name: Install Packages
run: npm ci
Expand All @@ -54,7 +54,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: npm
- name: Install Packages
run: npm ci
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/main-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
- name: Install Packages
run: npm ci
shell: bash
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr-preview-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ jobs:
name: Build
runs-on: ubuntu-latest
steps:
- uses: gravity-ui/preview-build-action@v1
- uses: gravity-ui/preview-build-action@v2
with:
node-version: 18
node-version: 20
2 changes: 1 addition & 1 deletion .github/workflows/pr-preview-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
github.event.workflow_run.conclusion == 'success'
runs-on: ubuntu-latest
steps:
- uses: gravity-ui/preview-deploy-action@v1
- uses: gravity-ui/preview-deploy-action@v2
with:
project: components
github-token: ${{ secrets.GRAVITY_UI_BOT_GITHUB_TOKEN }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release-beta.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:
exit 1
fi
fi
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
registry-url: 'https://registry.npmjs.org'
- run: npm ci
shell: bash
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,19 @@ name: Release

on:
push:
branches: [main]
branches:
- main
- release/v*

jobs:
release:
runs-on: ubuntu-latest
steps:
- uses: gravity-ui/release-action@v1
- name: Release from ${{ github.ref_name }}
uses: gravity-ui/release-action@v1
with:
github-token: ${{ secrets.GRAVITY_UI_BOT_GITHUB_TOKEN }}
npm-token: ${{ secrets.GRAVITY_UI_BOT_NPM_TOKEN }}
node-version: 18
node-version: 20
default-branch: ${{ github.ref_name != 'main' && github.ref_name || null }}
npm-dist-tag: ${{ github.ref_name != 'main' && 'untagged' || 'latest' }}
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
2 changes: 1 addition & 1 deletion .storybook/decorators/withLang.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import {settings} from '@gravity-ui/date-utils';
import {configure} from '@gravity-ui/uikit';
Expand Down
2 changes: 0 additions & 2 deletions .storybook/decorators/withMobile.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import React from 'react';

import {MobileProvider} from '@gravity-ui/uikit';
import type {Decorator} from '@storybook/react';

Expand Down
2 changes: 1 addition & 1 deletion .storybook/decorators/withStrictMode.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import type {Decorator} from '@storybook/react';

Expand Down
2 changes: 0 additions & 2 deletions .storybook/decorators/withTheme.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import React from 'react';

import {ThemeProvider} from '@gravity-ui/uikit';
import type {Decorator} from '@storybook/react';

Expand Down
64 changes: 0 additions & 64 deletions .storybook/docs.tsx

This file was deleted.

22 changes: 14 additions & 8 deletions .storybook/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,29 @@
const {join} = require('path');

const config: StorybookConfig = {
framework: {
name: '@storybook/react-webpack5',
options: {},
},

framework: '@storybook/react-webpack5',
stories: ['../src/**/*.stories.@(ts|tsx)'],

addons: [
'@storybook/preset-scss',
{
name: '@storybook/addon-styling-webpack',
options: {
rules: [
{
test: /\.s?css$/i,
use: ['style-loader', 'css-loader', 'sass-loader'],
},
],
},
},
{name: '@storybook/addon-essentials', options: {backgrounds: false}},
'./theme-addon/register.tsx',
'@storybook/addon-webpack5-compiler-babel',
'@storybook/addon-a11y',
'@storybook/addon-webpack5-compiler-babel',
],

webpackFinal: (storybookBaseConfig) => {
storybookBaseConfig?.module?.rules.push({
storybookBaseConfig?.module?.rules?.push({
test: /\.md$/,
include: [join(__dirname, '../src')],
use: [{loader: 'markdown-loader'}],
Expand All @@ -27,7 +33,7 @@

// to turn fileName in context.parameters into path form number in production bundle
if (storybookBaseConfig?.optimization) {
storybookBaseConfig.optimization.moduleIds = 'named';

Check warning on line 36 in .storybook/main.ts

View workflow job for this annotation

GitHub Actions / Verify Files

Assignment to property of function parameter 'storybookBaseConfig'
}

return storybookBaseConfig;
Expand Down
4 changes: 0 additions & 4 deletions .storybook/preview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,10 @@ import {withLang} from './decorators/withLang';
import {withMobile} from './decorators/withMobile';
import {withStrictMode} from './decorators/withStrictMode';
import {withTheme} from './decorators/withTheme';
import {Docs} from './docs';

const preview: Preview = {
decorators: [withLang, withMobile, withTheme, withStrictMode],
parameters: {
docs: {
page: Docs,
},
jsx: {showFunctions: true},
viewport: {
viewports: MINIMAL_VIEWPORTS,
Expand Down
2 changes: 1 addition & 1 deletion .storybook/theme-addon/register.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

import {getThemeType} from '@gravity-ui/uikit';
import {type API, addons, types, useGlobals} from '@storybook/manager-api';
Expand All @@ -22,6 +22,6 @@
const [{theme}] = useGlobals();
React.useEffect(() => {
api.setOptions({theme: themes[getThemeType(theme)]});
}, [theme]);

Check warning on line 25 in .storybook/theme-addon/register.tsx

View workflow job for this annotation

GitHub Actions / Verify Files

React Hook React.useEffect has a missing dependency: 'api'. Either include it or remove the dependency array
return null;
}
46 changes: 46 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,51 @@
# Changelog

## [4.0.1](https://github.com/gravity-ui/components/compare/v4.0.0...v4.0.1) (2025-02-07)


### Bug Fixes

* fix esm build ([#260](https://github.com/gravity-ui/components/issues/260)) ([3398560](https://github.com/gravity-ui/components/commit/3398560145b7d6936edb7b8cd579b53642d14fbb))

## [4.0.0](https://github.com/gravity-ui/components/compare/v3.13.2...v4.0.0) (2025-02-04)


### ⚠ BREAKING CHANGES

* update uikit
* **ActionsPanel:** remove component
* use ts target es2022
* major update Stories and StoriesGroup ([#256](https://github.com/gravity-ui/components/issues/256))
* prepare v4 release (deps + removals) ([#255](https://github.com/gravity-ui/components/issues/255))

### Features

* **ActionsPanel:** remove component ([8751b74](https://github.com/gravity-ui/components/commit/8751b74bb648bb8ca61c7c645421df2d5fbb40de))
* major update Stories and StoriesGroup ([#256](https://github.com/gravity-ui/components/issues/256)) ([abd9815](https://github.com/gravity-ui/components/commit/abd98158c74f251c46e030346a8a8ee8a75019d9))
* prepare v4 release (deps + removals) ([#255](https://github.com/gravity-ui/components/issues/255)) ([0633b74](https://github.com/gravity-ui/components/commit/0633b740a1dde06309b9965b85a1796e211ef80f))
* update uikit ([798e980](https://github.com/gravity-ui/components/commit/798e9801cd6087bc6f446840a5754e372deee6fd))
* update uikit ([b987225](https://github.com/gravity-ui/components/commit/b987225d62a75cb1ea2630d470b88565d21e2207))
* update uikit ([241a836](https://github.com/gravity-ui/components/commit/241a83644d0ae544e0ef5ab103851d99e4219829))
* update uikit ([b29686c](https://github.com/gravity-ui/components/commit/b29686cd41cf4e3369a862a96418d4084f44c47f))
* use ts target es2022 ([0ae913f](https://github.com/gravity-ui/components/commit/0ae913f29ed42b6cfbe4cdcdc8b441e0fdae1b5b))


### Bug Fixes

* a better solution for rounding Reactions' buttons ([9de1f35](https://github.com/gravity-ui/components/commit/9de1f35f01c599471541eaa321fb9d66277d7ca0))
* add exports field ([7663c45](https://github.com/gravity-ui/components/commit/7663c45c8371f78b673345fd68825a1480a9d33f))
* bundling and tests ([9d6540a](https://github.com/gravity-ui/components/commit/9d6540ae1c77019678b32384c7f8ff64271d13e4))
* **ConfirmDialog:** focus on apply to submit on Enter ([c529bb9](https://github.com/gravity-ui/components/commit/c529bb9b3d04c5f33bc642e6912f574182493ec4))
* lint issues ([368e7d4](https://github.com/gravity-ui/components/commit/368e7d468528541af8351989da0ab0810e5bc493))
* set 16px as border-radius for Reactions' buttons ([3918114](https://github.com/gravity-ui/components/commit/3918114817a3ae749984774dc5c3f86eaf92a533))

## [3.13.2](https://github.com/gravity-ui/components/compare/v3.13.1...v3.13.2) (2024-12-24)


### Bug Fixes

* rename unstable namespace keyset ([#253](https://github.com/gravity-ui/components/issues/253)) ([1d5052a](https://github.com/gravity-ui/components/commit/1d5052a308ad1208a1df99b9109d72e0b00f04f9))

## [3.13.1](https://github.com/gravity-ui/components/compare/v3.13.0...v3.13.1) (2024-12-16)


Expand Down
4 changes: 2 additions & 2 deletions CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
* @amje @ValeraS @korvin89
/src/components/AdaptiveTabs @artemipanchuk
/src/components/AdaptiveTabs
/src/components/DefinitionList @Raubzeug
/src/components/FilePreview @KirillDyachkovskiy
/src/components/FilePreview @mournfulCoroner
/src/components/FormRow @ogonkov
/src/components/HelpPopover @Raubzeug
/src/components/Notifications @Ruminat
Expand Down
Loading
Loading