-
Notifications
You must be signed in to change notification settings - Fork 2k
docs: update "going to production" guide #4398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjie
requested changes
May 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good! I'm going to follow up with a commit to add trusted documents to the advice, users who use trusted documents can mostly skip over disabling introspection, query cost analysis, and similar concerns.
benjie
approved these changes
May 29, 2025
Follow up with trusted documents can be found here: #4418 |
benjie
added a commit
that referenced
this pull request
May 29, 2025
Expands on #4398 by recommending the trusted documents pattern which 90+% of GraphQL users should be using.
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
May 30, 2025
Updates "Going to Production" guide to cover a larger scope. The goal is to cover most bases on what devs should consider before deploying to production. I also added a checklist. --------- Co-authored-by: Benjie <[email protected]>
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
May 30, 2025
Expands on graphql#4398 by recommending the trusted documents pattern which 90+% of GraphQL users should be using.
yaacovCR
pushed a commit
that referenced
this pull request
May 30, 2025
Updates "Going to Production" guide to cover a larger scope. The goal is to cover most bases on what devs should consider before deploying to production. I also added a checklist. --------- Co-authored-by: Benjie <[email protected]>
yaacovCR
pushed a commit
that referenced
this pull request
May 30, 2025
Expands on #4398 by recommending the trusted documents pattern which 90+% of GraphQL users should be using.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates "Going to Production" guide to cover a larger scope. The goal is to cover most bases on what devs should consider before deploying to production. I also added a checklist.
I will preface that this is a bit of a long page, but useful to have
Not ready for review yet, still proofreading/cleaning up