Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement onError proposal #4364

Open
wants to merge 7 commits into
base: 16.x.x
Choose a base branch
from
Open

Implement onError proposal #4364

wants to merge 7 commits into from

Conversation

benjie
Copy link
Member

@benjie benjie commented Mar 27, 2025

@benjie benjie requested a review from a team as a code owner March 27, 2025 17:58
@benjie benjie mentioned this pull request Mar 27, 2025
Open
@github-actions GitHub Actions
Copy link

Hi @benjie, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@benjie benjie mentioned this pull request Mar 27, 2025
Draft
5 tasks
@benjie

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

@github-actions publish-pr-on-npm

@benjie The latest changes of this PR are available on NPM as
graphql@16.10.0-canary.pr.4364.6b142546832c1283b535908fb8c9a171b2f7cc20
Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR:
npm install --save graphql@canary-pr-4364

JoviDeCroock
JoviDeCroock approved these changes Apr 6, 2025
View reviewed changes
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not opposed to this but what are we doing with the directive that is present on main/v17?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjie @JoviDeCroock