-
Notifications
You must be signed in to change notification settings - Fork 2k
Added specific eslint rules for typescript tests #2634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -632,6 +632,18 @@ overrides: | |
'@typescript-eslint/type-annotation-spacing': off | ||
- files: '**/__*__/**' | ||
rules: | ||
'@typescript-eslint/consistent-type-assertions': | ||
[error, { assertionStyle: as, objectLiteralTypeAssertions: allow }] | ||
'@typescript-eslint/no-non-null-assertion': off | ||
'@typescript-eslint/restrict-plus-operands': off | ||
'@typescript-eslint/no-floating-promises': off | ||
'@typescript-eslint/no-invalid-this': off | ||
'@typescript-eslint/no-throw-literal': off | ||
'@typescript-eslint/require-await': off | ||
'@typescript-eslint/await-thenable': off | ||
'prefer-promise-reject-errors': 0 | ||
'no-new-wrappers': 0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are standard ESLint rules so they should work on both Flow and TS. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some of the tests are creating wrapped instances of primitives (for example - |
||
'no-throw-literal': 0 | ||
dotansimha marked this conversation as resolved.
Show resolved
Hide resolved
|
||
node/no-unpublished-import: off | ||
node/no-unpublished-require: off | ||
import/no-restricted-paths: off | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please use
off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No all rules allow

off
as value, it gives an error. I think only TS rules allowoff
value.