Skip to content

Conversation

dotansimha
Copy link
Member

@dotansimha dotansimha commented Jun 5, 2020

Originally from: #2609 , those fixes are required in order to make the tests compatible with TS.

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Jun 5, 2020
@IvanGoncharov
Copy link
Member

@dotansimha All the fixes in existing *.d.ts files look good but new typing requires an extra review.
So can you please extract fixes to existing files into separate PR?

@dotansimha dotansimha changed the title Fixes for d.ts files Added .d.ts files for test utils Jun 7, 2020
@dotansimha
Copy link
Member Author

@IvanGoncharov I saw you already moved the fixes to a new PR and merged, so that's great! Thank you.
I rebased and applied the fixes.

Do you think I should rebase #2609 to this PR? because those changes are needed in order to support the TS tests.

@Urigo Urigo mentioned this pull request Sep 26, 2020
6 tasks
@dotansimha dotansimha mentioned this pull request Dec 1, 2020
17 tasks
Base automatically changed from master to main January 27, 2021 11:10
@yaacovCR
Copy link
Contributor

This can be closed considering that the code base has been converted to TS.

Thank you @dotansimha for your work on this, which has been integrated into other PRs as well as for your energy and initiative in pushing forward the migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: bug fix 🐞 requires increase of "patch" version number

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants