Skip to content

Enum other variant for fragments #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 1, 2021
Merged

Enum other variant for fragments #376

merged 4 commits into from
Oct 1, 2021
+240 −4

Conversation

visd0m
Copy link
Contributor

@visd0m visd0m commented Jul 10, 2021

Reopen #373 accidentally closed due to base branch rename from master to main

@visd0m
Copy link
Contributor Author

visd0m commented Jul 14, 2021

@tomhoule this pr reopen the #373

@tomhoule
Copy link
Member

Thanks! I'll try to find time to review as soon as possible.

@visd0m
Copy link
Contributor Author

visd0m commented Oct 1, 2021

@tomhoule what about this pr? If you don't have time to review it can you suggest me some other reviewer?

tomhoule
tomhoule approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @visd0m , I indeed very rarely find time for graphql-client. The PR looks, good let's merge, thanks 👍

For anyone else who might be reading, external reviews are very much appreciated.

@tomhoule tomhoule merged commit 9685a9d into graphql-rust:main Oct 1, 2021
@visd0m visd0m deleted the enum-other-variant-for-fragments branch January 10, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@visd0m @tomhoule