Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disble mouse scroll #437

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

mac2000
Copy link
Contributor

@mac2000 mac2000 commented Jan 1, 2025

Here is accompanying pull request that closes #436 feature request

TLDR:

provide disable mouse scroll setting

motivation: for a use cases when Voyager is just a part of bigger page, its current behavior brakes page scroll experience

notes:

  • new setting by intent named in this way so it is backward compatibe, opt-in
  • by intent other settings were not touched, but may be exposed as well when needed
  • did tried to keep changes as small as possible so did not changed anything unrelevant

@mac2000
Copy link
Contributor Author

mac2000 commented Jan 1, 2025

Unfortunately there is an issue with one of the tests

Error:  |     Error: [ERROR] at 'http://serve-webpack-example:9090/?:0': Access to fetch at 'https://swapi-graphql.netlify.app/.netlify/functions/index' from origin 'http://serve-webpack-example:9090' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

Notes:

  1. endpoint is not working at moment (trying to open https://swapi-graphql.netlify.app i see white page)
  2. it responds with 301 to /graphql and if we call it directly we receive 415
  3. there is https://graphql.org/swapi-graphql/ but under the hood it calls same endpoint and does not work as well

having that in place, not sure if I can fix this without making more changes that needed for this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable mouse scroll
1 participant