Repository navigation
Support graphql-java 26 - #818
Merged
Merged
Conversation
graphql-java 26.0 removed graphql.schema.idl.DirectiveInfo, which made schema creation fail with NoClassDefFoundError. - bump graphql-java 25.0 -> 26.1 - look up built-in directives via Directives.BUILT_IN_DIRECTIVES_MAP - give a bare @deprecated its default reason (like graphql-java's SchemaGenerator), so SchemaPrinter / federation _service.sdl can print it - pass the dictionary as named types (narrowed additionalTypes signature) - adapt to graphql-java 26 JSpecify nullability (no behaviour change) Closes graphql-java-kickstart#815
Collaborator
|
@pfyod thanks for the contribution. I'll review this soon. |
Build the built-in directive map from the individual Directives constants instead of Directives.BUILT_IN_DIRECTIVES_MAP, which only exists in graphql-java 26, so the same jar works with both 25 and 26. Also clarify where the default @deprecated reason comes from and add a TODO to narrow SchemaObjects.dictionary in the next major version. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
oryan-block
approved these changes
Oct 3, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
graphql-java 26.0 removed graphql.schema.idl.DirectiveInfo, which made schema creation fail with NoClassDefFoundError.
Closes #815