refactor: drop the redundant invalid-UTF-8 catch - #238
Open
MoonBoi9001 wants to merge 1 commit into
Open
MoonBoi9001 wants to merge 1 commit into
MoonBoi9001 wants to merge 1 commit into
Conversation
MoonBoi9001
added this pull request to stack #242
September 10, 2026 13:51
MoonBoi9001
marked this pull request as ready for review
September 10, 2026 13:54
The graph-node version fetcher listed both ValueError and UnicodeDecodeError in the errors it swallows per indexer, but the second is a subclass of the first, so it was already caught. The existing invalid-UTF-8 test still passes with the extra entry gone.
MoonBoi9001
force-pushed
the
mb9/drop-redundant-unicode-error-catch
branch
from
September 10, 2026 14:15
e9c951d to
1c4c8b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the invalid-UTF-8 error from the list of errors the graph-node version fetcher tolerates per indexer, because it is a subclass of the value error already in that list and was never reached.