refactor: split score orchestration into named stages - #237
Open
MoonBoi9001 wants to merge 1 commit into
Open
MoonBoi9001 wants to merge 1 commit into
MoonBoi9001 wants to merge 1 commit into
Conversation
MoonBoi9001
added this pull request to stack #242
September 10, 2026 13:51
MoonBoi9001
marked this pull request as ready for review
September 10, 2026 13:54
The function that runs a full scoring pass did GeoIP demotion, neutral column filling, the whole latency regression and the DIP pricing merge inline, which made its branching hard to follow. Each of those is now its own helper and the orchestrator reads as a short sequence.
MoonBoi9001
force-pushed
the
mb9/split-score-orchestration-into-stages
branch
from
September 10, 2026 14:15
6fc5565 to
3928ac9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits the function that runs 1 full scoring pass into named stages (resolve location, score latency, merge, transform) with no intended change to the scores, and adds an end-to-end test for the partial no-GeoIP path.