refactor: name the standard error column once - #233
Open
MoonBoi9001 wants to merge 1 commit into
Open
MoonBoi9001 wants to merge 1 commit into
MoonBoi9001 wants to merge 1 commit into
Conversation
MoonBoi9001
added this pull request to stack #242
September 10, 2026 13:51
MoonBoi9001
marked this pull request as ready for review
September 10, 2026 13:53
The latency regression labels each coefficient's standard error with a column called "Standard Error", and 6 places spelled that name out by hand. This adds 1 named constant so a typo in any of them can no longer silently produce a missing column.
MoonBoi9001
force-pushed
the
mb9/name-the-standard-error-column-once
branch
from
September 10, 2026 14:15
b6cf28c to
435d3b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces 6 hand-typed copies of the column name "Standard Error" in the scoring pipeline with 1 named constant, so a typo can no longer silently produce a missing column.