Remove substreams support #6261
Merged
+59
−10,316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fordN
requested review from
dwerner,
incrypto32 and
isum
and removed request for
incrypto32
dwerner
approved these changes
Jan 8, 2026
Contributor
dwerner
left a comment
dwerner
left a comment
There was a problem hiding this comment.
lgtm! Seems to me like a clean cut.
lutter
force-pushed
the
lutter/no-substreams
branch
2 times, most recently
from
fabd34c to
e9a3dbb
Compare
This was only used for substreams
We need to eventually fix that, but that requires quite a bit of change. For now, we suppress the clippy warning.
lutter
force-pushed
the
lutter/no-substreams
branch
from
e9a3dbb to
8bba01e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substreams have been unsupported on the network for quite some time now. Since the code backing substreams is substantial and introduced quite a few parallel code paths, it's best to remove it.
This PR removes most of the code for it, though there might still be some places where now dead substreams code lingers. There are probably also various opportunities to simplify code further now that a lot of the bifurcation of logic that substreams added has been removed. This PR does not address that yet, we should address that over time as we make changes to code that can be simplified further.