fix: add recurring collector parameter to deploy configs#1332
Closed
MoonBoi9001 wants to merge 1 commit into
Closed
fix: add recurring collector parameter to deploy configs#1332MoonBoi9001 wants to merge 1 commit into
MoonBoi9001 wants to merge 1 commit into
Conversation
Closed
MoonBoi9001
force-pushed
the
mb9/dips-local-testing-fixes-v2
branch
from
2a63a80 to
36c70b1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## deployment/testnet/2024-05-09/gip-0088 #1332 +/- ##
=======================================================================
Coverage 91.16% 91.16%
=======================================================================
Files 81 81
Lines 5318 5318
Branches 1128 1128
=======================================================================
Hits 4848 4848
Misses 448 448
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
You might want to rebased on top of: deployment/testnet/2024-05-06/gip-0088 |
Base automatically changed from
indexing-payments-management-audit-fixed-rebased
to
main
May 9, 2026 10:24
MoonBoi9001
changed the base branch from
main
to
deployment/testnet/2024-05-09/gip-0088
MoonBoi9001
force-pushed
the
mb9/dips-local-testing-fixes-v2
branch
2 times, most recently
from
210be45 to
dd6598d
Compare
The SubgraphService deployment script reads a recurringCollectorAddress parameter at deploy time, but neither the default nor the local-network parameter file lists it. Any deployment using those files fails when the parameter can't be found. Add the slot to both. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
MoonBoi9001
force-pushed
the
mb9/dips-local-testing-fixes-v2
branch
from
dd6598d to
d3d3790
Compare
MoonBoi9001
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds the missing
recurringCollectorAddressslot to two deployment config files. Two lines per file, no logic changes.Motivation
Ignition deploys contracts by reading parameter files keyed by network — each file lists every input the deployment module expects. The SubgraphService module asks for a recurring collector address when wiring up its implementation, but neither the default file nor the local-network file declares that key. Any deployment using either of these files aborts before any contract is touched. This blocks the local-network end-to-end DIPs testing pipeline and any other deployment that inherits from the default config.
Summary
recurringCollectorAddressentry toprotocol.default.json5recurringCollectorAddressentry toprotocol.localNetwork.json5