Skip to content

Modernise and cleanup lint configuration and build process #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
59b6e76
feat: lint and build upgrade
RembrandtK May 21, 2025
cdc7ef9
feat: lint and build upgrade
RembrandtK May 21, 2025
4a4bbab
Merge remote-tracking branch 'refs/remotes/origin/rem/lint-upgrade' i…
RembrandtK May 21, 2025
8d68581
fix: setting node-version to 20
RembrandtK May 21, 2025
30a1938
fix: downgrade typechain deps for compatibility with ethers v5
RembrandtK May 21, 2025
5f44c19
fix: module upgrades and code changes to fix build and test
RembrandtK May 22, 2025
b236d3b
fix: update typechain patch
RembrandtK May 22, 2025
a6c4e79
fix: coverage tests, package versions
RembrandtK May 22, 2025
6fdf2e6
fix: updating references to increased package versions
RembrandtK May 22, 2025
99607df
fix: yarn.lock update
RembrandtK May 22, 2025
ea09d5f
fix: removing container name from docker-compose
RembrandtK May 23, 2025
20584c6
fix: reverting unneeded hacks to test code
RembrandtK May 23, 2025
7147ea8
fix: test:coverage
RembrandtK May 23, 2025
887230e
chore: solidity-coverage version update and related token-distributio…
RembrandtK May 24, 2025
8bfc50b
fix: attempt to fix GH workflows
RembrandtK May 24, 2025
2b4b7d5
fix: attempt to fix GH workflows
RembrandtK May 24, 2025
5267dd9
fix: set ADDRESS_BOOK to address.json for CI
RembrandtK May 24, 2025
a538915
fix: attempt to fix GH workflow coverage options
RembrandtK May 24, 2025
9168b4f
fix: attempting to fix GH workflow coverage test
RembrandtK May 24, 2025
688b9cf
fix: trying to use original coverage script for CI
RembrandtK May 24, 2025
6255d60
fix: build all packages first for CI, not just contracts
RembrandtK May 24, 2025
a3b9d33
fix: build only sdk and contracts for contracts CI, not all packages
RembrandtK May 24, 2025
c38ae95
fix: changing build order for CI
RembrandtK May 24, 2025
6c9aae4
fix: updating to use artifacts dir
RembrandtK May 24, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .devcontainer/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
services:
dev-graph-contracts:
container_name: dev-graph-contracts
build:
context: .
dockerfile: Dockerfile
Expand Down
7 changes: 6 additions & 1 deletion .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,18 @@ runs:
using: composite

steps:
- name: Install system dependencies
shell: bash
run: |
sudo apt-get update
sudo apt-get install -y libudev-dev libusb-1.0-0-dev
- name: Enable corepack for modern yarn
shell: bash
run: corepack enable
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: 'yarn'
- name: Install dependencies
shell: bash
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/ci-contracts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ env:

on:
push:
branches: "*"
branches: '*'
paths:
- packages/contracts/**
pull_request:
branches: "*"
branches: '*'
paths:
- packages/contracts/**
workflow_dispatch:
Expand All @@ -22,10 +22,13 @@ jobs:
uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
- name: Build
- name: Build dependencies
run: |
pushd packages/contracts
yarn build || yarn build
yarn build
popd
pushd packages/sdk
yarn build
- name: Run tests
run: |
pushd packages/contracts
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/ci-data-edge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ env:

on:
push:
branches: "*"
branches: '*'
paths:
- packages/data-edge/**
pull_request:
branches: "*"
branches: '*'
paths:
- packages/data-edge/**
workflow_dispatch:
Expand All @@ -27,4 +27,6 @@ jobs:
pushd packages/data-edge
yarn build
- name: Run tests
run: yarn test
run: |
pushd packages/data-edge
yarn test
12 changes: 9 additions & 3 deletions .github/workflows/ci-token-dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ env:

on:
push:
branches: "*"
branches: '*'
paths:
- packages/token-distribution/**
pull_request:
branches: "*"
branches: '*'
paths:
- packages/token-distribution/**
workflow_dispatch:
Expand All @@ -23,9 +23,15 @@ jobs:
uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
- name: Build contracts (dependency)
run: |
pushd packages/contracts
yarn build
- name: Build
run: |
pushd packages/token-distribution
yarn build
- name: Run tests
run: yarn test
run: |
pushd packages/token-distribution
yarn test
Loading
Loading