chore: bump pre-commit hook versions#881
Open
sevmag wants to merge 2 commits into
Open
Conversation
730b07b to
74d05fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE:
The large amount of changed files is only a relic from running the new linting on the whole repo the only real change is in .pre-commit-config.yaml
Summary
Updates pinned versions in
.pre-commit-config.yamlto current upstream tags. The previous pins were ~1 year old and the olderflake8 7.1.1/black 24.10.0releases trigger a deprecatedbdist_wheel.universalcodepath that fails to install cleanly on certain pip + setuptools combinations (we saw[Errno 17] File exists: 'build/bdist.linux-x86_64/wheel/<pkg>.dist-info'during fresh hook env installs). Newer releases ship prebuilt wheels and avoid the legacy install path.Changes:
NameError: tomllib is not definedregression on Python 3.10 (uses 3.11+ stdlib unconditionally), so v1.7.7 is kept.Test plan
pre-commit run --all-files(or on changed files) passes locally with the new pins