Skip to content

Fix typo in "Faux has_one" guide #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typo in "Faux has_one" guide #43

wants to merge 1 commit into from

Conversation

jelaniwoods
Copy link

I noticed this typo while reading the docs. Here's a small PR to fix it.

Zooip
Zooip suggested changes Jul 20, 2022
View reviewed changes
Copy link

@Zooip Zooip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to compile your changes first (see Readme.md)

Zooip
Zooip approved these changes Jul 20, 2022
View reviewed changes
Copy link

@Zooip Zooip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, it's done in CI, my bad.

@jelaniwoods
Copy link
Author

@Zooip is there anything else I need to do for this PR? Or can it be merged?

@Zooip
Copy link

Zooip commented Nov 20, 2022

It can be merged as far as I know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Zooip Zooip Zooip approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jelaniwoods @Zooip