Conversation
.github/workflows/publish-conda.yml
Outdated
| with: | ||
| subDir: 'conda' | ||
| AnacondaToken: ${{ secrets.ANACONDA_TOKEN }} | ||
| platforms: 'linux' No newline at end of file |
There was a problem hiding this comment.
Is there a prepublish test we can do? Ex: In pip, we do a test publish to test.pypi.org first
There was a problem hiding this comment.
After researching, I don't belive that there is a way to perform a test publish for conda
conda/meta.yaml
Outdated
| @@ -0,0 +1,65 @@ | |||
| package: | |||
| name: graphistry-dev | |||
| version: "0.25.2" | |||
There was a problem hiding this comment.
The version seems hard-coded here, while it should be taken from the git tag -- am I misreading somehow?
There was a problem hiding this comment.
There was a problem hiding this comment.
Working on it, for some reason this env variable is not present
There was a problem hiding this comment.
Resolved by switching to different github action
conda/meta.yaml
Outdated
| - name: graphistry_dev.graphistry-umap | ||
| requirements: | ||
| - umap-learn | ||
| - dirty_cat |
There was a problem hiding this comment.
See setup.py for min dirty_cat version req + add scikit-learn (with min version)
conda/meta.yaml
Outdated
| - dirty_cat | ||
| - name: graphistry_dev.graphistry-ai | ||
| requirements: | ||
| - scikit-learn |
There was a problem hiding this comment.
see setup.py for min version reqs
|
|
||
| outputs: | ||
| - name: graphistry_dev.graphistry_core | ||
| requirements: |
There was a problem hiding this comment.
is there anything like outputs.*.description where they can point to the main conda package for instructions?
There was a problem hiding this comment.
We can put instructions in the main description and it will be used for all outputs
There was a problem hiding this comment.
You can check here to see how the description looks like right now
conda/meta.yaml
Outdated
|
|
||
| about: | ||
| home: https://www.graphistry.com/ | ||
| license: BSD |
conda/meta.yaml
Outdated
| about: | ||
| home: https://www.graphistry.com/ | ||
| license: BSD | ||
| summary: Visual Graph Analytics library for Python |
There was a problem hiding this comment.
Graphistry Visual Graph ...
conda/meta.yaml
Outdated
| description: | | ||
| Graphistry is a visual graph analytics library for extracting, transforming, | ||
| displaying, and sharing big graphs with end-to-end GPU acceleration | ||
| doc_url: https://www.graphistry.com/docs |
There was a problem hiding this comment.
conda/meta.yaml
Outdated
| @@ -0,0 +1,65 @@ | |||
| package: | |||
| name: graphistry-dev | |||
There was a problem hiding this comment.
Guessing as part of landing, change to graphistry ?
There was a problem hiding this comment.
Getting there! See per-line reviews:
- Parameterize version by git tag (we use
X.Y.Z, in case conda needs a prefix) - Update dependencies, esp. min versions
- Various individual settings changes
And some questions:
- How should pre-publishing testing work?
- Can we put instructions somewhere to guide users on different ways to install?
|
@lmeyerov Answering you question about testing:
Other issues have been resolved as well as the possible answer to instruction, you can check them. |
lmeyerov
left a comment
lmeyerov
left a comment
There was a problem hiding this comment.
lgtm - will try on prod!
2 participants
To install all:
conda install -c pygraphistry_dev graphistry-devTo install one package:
conda install -c pygraphistry_dev graphistry_dev.graphistry_coreRight now action is only run manually.
Currently configured for the dev anaconda account