-
Notifications
You must be signed in to change notification settings - Fork 230
perf(pagerank): add fast, bounded, and memory-aware auto paths #2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lmeyerov
wants to merge
5
commits into
feat/gfql-std-procedures
Choose a base branch
from
perf/std-pagerank-fast-bounded
base: feat/gfql-std-procedures
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
68e6cc4
perf: add fast and bounded pagerank modes
lmeyerov 5746988
perf: accelerate cudf pagerank fast path
lmeyerov 65f19fb
feat: guard pagerank auto mode by memory
lmeyerov 7022fe7
fix: satisfy full pagerank type checks
lmeyerov ec039cd
test: cover pagerank memory preflight
lmeyerov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,11 +22,11 @@ | |
| from __future__ import annotations | ||
|
|
||
| from types import ModuleType | ||
| from typing import Iterator, Mapping, Optional, Sequence, SupportsInt, Tuple | ||
| from typing import Iterator, Mapping, Optional, Sequence, SupportsFloat, SupportsInt, Tuple | ||
|
|
||
| import pandas as pd | ||
|
|
||
| from graphistry.compute.typing import DataFrameT, SeriesT | ||
| from graphistry.compute.typing import ArrayLike, ArrayNamespace, DataFrameT, SeriesT | ||
|
|
||
| # 2**32, as a plain Python int. Used for bit-packing via arithmetic. | ||
| SHIFT32 = 1 << 32 | ||
|
|
@@ -37,6 +37,44 @@ def is_cudf(obj: object) -> bool: | |
| return type(obj).__module__.split(".")[0] == "cudf" | ||
|
|
||
|
|
||
| def array_namespace(template: object) -> ArrayNamespace: | ||
| """NumPy or CuPy for the dataframe or Series engine holding the template.""" | ||
| if is_cudf(template): | ||
| import cupy | ||
|
|
||
| return cupy | ||
| import numpy | ||
|
|
||
| return numpy # type: ignore[return-value] | ||
|
|
||
|
|
||
| def series_to_array(series: SeriesT) -> ArrayLike: | ||
| """A host or device array view of a dense positional Series.""" | ||
| if is_cudf(series): | ||
| return series.values | ||
| return series.to_numpy() | ||
|
|
||
|
|
||
| def series_from_array(template: object, values: ArrayLike) -> SeriesT: | ||
| """Build a default-index Series on the same engine as the template.""" | ||
| if is_cudf(template): | ||
| import cudf | ||
|
|
||
| return cudf.Series(values) | ||
| return pd.Series(values) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Send most of these live in our SeriesT / DataframeT cross platform files ? |
||
|
|
||
|
|
||
| def to_host_floats(values: Sequence[SupportsFloat]) -> tuple[float, ...]: | ||
| """Transfer several backend scalars together, requiring one GPU sync.""" | ||
| if not values: | ||
| return () | ||
| if type(values[0]).__module__.split(".")[0] == "cupy": | ||
| import cupy | ||
|
|
||
| return tuple(float(value) for value in cupy.asnumpy(cupy.stack(values))) | ||
| return tuple(float(value) for value in values) | ||
|
|
||
|
|
||
| def _mod(frame: DataFrameT) -> ModuleType: | ||
| """The dataframe module that produced `frame` (pandas or cudf).""" | ||
| if is_cudf(frame): | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought should be clear that the main value of this implementation is lower memory consumption for handling bigger graphs on smaller GPUs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise, typically better to use the GPU or CPU ones when fit in memory