Skip to content

ci: test-docs lane skips on docs-only PRs (needs python-lint-types, which skips) #2018

Description

@lmeyerov

Observed

PR #2017 changes only docs/source/** and CHANGELOG.md. The changes job sets docs=true, and test-docs has the intended condition (docs == 'true' && narrow_python_only != 'true'), but the job is still skipped.

Cause: test-docs declares needs: [changes, python-lint-types, docs-latex-unicode-guard] (.github/workflows/ci.yml line ~2048). python-lint-types skips when no Python changed, and a skipped needs dependency skips the dependent job regardless of its if: unless the condition includes always() / !cancelled().

Result: docs-only PRs never run the Sphinx build in CI. The Read the Docs PR preview is the only build signal.

Fix options

  • Add !cancelled() && to the test-docs if: and check needs.python-lint-types.result is success or skipped, or
  • drop python-lint-types from needs for test-docs (the docs build does not depend on lint).

Found while opening #2017.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WwMmVFo44ADiRRj5cxh7i1

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions