Update constantine backend #291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtiomTr
force-pushed
the
update-constantine-backend
branch
from
27fc236 to
4083b3e
Compare
|
Thanks, but seems it fails? |
|
Yeah, still fighting clippy issues :) |
ArtiomTr
force-pushed
the
update-constantine-backend
branch
from
4083b3e to
e2bba8b
Compare
ArtiomTr
force-pushed
the
update-constantine-backend
branch
3 times, most recently
from
3fa99a3 to
8206d66
Compare
|
Macos constantine currently fails, I see there was PR in constantine mratsim/constantine#517 about some issue in macos, but it is not currently merged into |
ArtiomTr
force-pushed
the
update-constantine-backend
branch
from
8206d66 to
d9fae11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
branch = ...specifier withrev = ..., because when I tried to add constantine backend to grandine, cargo picked up latest commit in branch, and build failed, as constantine has changed some function names. I believe this happens because cargo always picks latest commit in branch. To make builds not break in future, I've specified latest commit in that branch withrev =.Pin<Box<>>.Needed for grandinetech/grandine#88